[jira] [Updated] (JCR-3602) Don't swallow exception infos when logging RepositoryException in ACLProvider

["Daniel Lipp (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/JCR-3602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Lipp updated JCR-3602:
-----------------------------

    Status: Patch Available  (was: Open)

    } catch (RepositoryException e) {
        // should never get here
        log.warn("Internal error.", e);
    }
                
> Don't swallow exception infos when logging RepositoryException in ACLProvider
> -----------------------------------------------------------------------------
>
>                 Key: JCR-3602
>                 URL: https://issues.apache.org/jira/browse/JCR-3602
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 2.6.1
>            Reporter: Daniel Lipp
>
> org.apache.jackrabbit.core.security.authorization.principalbased.ACLProvider#getEditor(Session) and acModified(AccessControlModifications) use the following catch for RepositoryExceptions:
>     } catch (RepositoryException e) {
>         // should never get here
>         log.warn("Internal error: ", e.getMessage());
>     }
> Unfortunately the format string doesn't contain a variable so the message of the caught RepositoryException is swallowed. As there's no stacktrace either, users will only get "Internal error: " in their logs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira