[GitHub] [avro] areese opened a new pull request #1034: avrogencpp has tabs in CodeGen::generateEnumTraits, which is inconsistent with the rest of the generated code.

[GitBox <gi...@apache.org>]

areese opened a new pull request #1034:
URL: https://github.com/apache/avro/pull/1034


   avrogencpp has tabs in CodeGen::generateEnumTraits, which is inconsistent with the rest of the generated code.
   
   This commit replaces all of the tabs in the CodeGen::generateEnumTraits function with 4 spaces to match the formatting of the rest of the file as well as the rest of the generated code.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
     - https://issues.apache.org/jira/browse/AVRO-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: 
        This PR changes the whitespace in the generated avrogencpp code, which I did not find unit tests for.
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] RyanSkraba merged pull request #1034: avrogencpp has tabs in CodeGen::generateEnumTraits, which is inconsistent with the rest of the generated code.

[GitBox <gi...@apache.org>]

RyanSkraba merged pull request #1034:
URL: https://github.com/apache/avro/pull/1034


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] areese commented on pull request #1034: avrogencpp has tabs in CodeGen::generateEnumTraits, which is inconsistent with the rest of the generated code.

[GitBox <gi...@apache.org>]

areese commented on pull request #1034:
URL: https://github.com/apache/avro/pull/1034#issuecomment-763781735


   @RyanSkraba I agree.  I saw the other tabs, but this was very visible in the generated code.
   I didn't want to wholesale change all of the tabs, because while different whitespace is visibly annoying, changing it can easily introduce unintentional bugs.
   
   Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org