[jira] Commented: (SYNAPSE-349) Transport base package is dependent on transport specific (VFS and Mail) classes

["Andreas Veithen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SYNAPSE-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603131#action_12603131 ] 

Andreas Veithen commented on SYNAPSE-349:
-----------------------------------------

Two comments:
* getMinPollTime doesn't seem to be used anywhere. We might as well remove it completely, given that the logic of that method is not very sophisticated and it would be easy to reimplement it when the need for it arises.
* Your patch partially undoes the modifications introduced to solve SYNAPSE-260 and will cause a regression. These modifications addressed a problem that appeared in the VFS transport. If they break other transports, then we need to figure out another solution that works correctly for all transports.

> Transport base package is dependent on transport specific (VFS and Mail) classes
> --------------------------------------------------------------------------------
>
>                 Key: SYNAPSE-349
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-349
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 1.2
>            Reporter: Oleg Kalnichevski
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: basetransport.patch
>
>
> The base transport package of Synapse is dependent on VFS and Mail specific classes, which seems wrong to me. Ideally the base transport classes should not depend on any transport specific aspects. 
> Patch to follow shortly.
> Oleg

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org