You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/10/27 13:55:16 UTC

[GitHub] [sling-org-apache-sling-feature-analyser] karlpauls commented on a change in pull request #26: Rework the analyser to report more context and improve the meta data …

karlpauls commented on a change in pull request #26:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/26#discussion_r512711561



##########
File path: src/main/java/org/apache/sling/feature/analyser/Analyser.java
##########
@@ -236,29 +244,80 @@ public BundleDescriptor getFrameworkDescriptor() {
 
                 @Override
                 public void reportWarning(final String message) {
-                    warnings.add(message);
+                    if (analyserMetaDataExtension != null && analyserMetaDataExtension.reportWarning(feature.getId())) {

Review comment:
       @cziegeler, good catch! This was supposed to be the other way around - I fixed it. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org