You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by optikalefx <gi...@git.apache.org> on 2014/08/22 16:48:53 UTC
[GitHub] cordova-plugin-dialogs pull request: Progress dialogs should be ca...
GitHub user optikalefx opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/28
Progress dialogs should be cancellable outside the window
This change makes progress dialogs modal. In a sense that they can't be cancelled from an outside touch. This is expected behavior for a progress bar. Too many user errors by mis-tapping outside the progress and then having no clue what happened.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ConnectAi/cordova-plugin-dialogs master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-dialogs/pull/28.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #28
----
commit 51be8503bb1510ca151d7ee77a37ffde02bf6017
Author: Sean Clark <se...@connectai.com>
Date: 2014-08-22T14:46:57Z
Progress dialogs should be cancellable outside the window
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-dialogs pull request: Progress dialogs should be no...
Posted by optikalefx <gi...@git.apache.org>.
Github user optikalefx commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/28#issuecomment-53110589
The current implementation allows the progress 1-100 dialog box to be cancelled by clicking outside the dialog window. This is unexpected behavior for the user.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-dialogs pull request: Progress dialogs should be no...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/28#issuecomment-53111051
The issue as I meant to imply it is that only Android supports this functionality, ultimately it should be moved/removed, or implemented for more platforms.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-dialogs pull request: Progress dialogs should be ca...
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/28#issuecomment-53106919
I'm pretty sure that the pull request title doesn't match the description/implementation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-dialogs pull request: Progress dialogs should be ca...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/28#issuecomment-53106398
What are progress dialogs ??
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-dialogs pull request: Progress dialogs should be ca...
Posted by optikalefx <gi...@git.apache.org>.
Github user optikalefx commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/28#issuecomment-53110469
Sorry about the whitespace. Automatic sublime setting.
A progress dialog (`notification.progressDialog` is a dialog that has a 1-100 progressbar. The user should not be able to click away. You're right the title should say "not cancellable." I'll update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-dialogs pull request: Progress dialogs should be no...
Posted by optikalefx <gi...@git.apache.org>.
Github user optikalefx commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/28#issuecomment-53111223
iOS is modal by default already. So it already performs the expected behavior. I don't know about the other platforms. At least on Android this is a necessary change, and on iOS we didn't have to do anything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---