[GitHub] [flink] akalash commented on pull request #16772: [FLINK-23560][runtime] Calculate absoluteTimeMillis only once for idle metric and throughput calculation.

[GitBox <gi...@apache.org>]

akalash commented on pull request #16772:
URL: https://github.com/apache/flink/pull/16772#issuecomment-897804261


   Benchmark results for different cases:
   Result before degradation: sortedMultiInput(~2145), sortedTwoInput(~2000)
   Current result in master: sortedMultiInput(~2050), sortedTwoInput(~1940)
   Fresh master with reverted problematic commit(my target): sortedMultiInput(~2130), sortedTwoInput(~2030)
   These changes applied to master: sortedMultiInput(~2120), sortedTwoInput(~2020)
   
   Optimization(FLINK-23648) applied right before degradation: sortedMultiInput(~2145), sortedTwoInput(~2050)
   Optimization(FLINK-23648) applied right after degradation + these fix: sortedMultiInput(~2130), sortedTwoInput(~2040)
   
   My conclusion: This fix fixes the major drop from FLINK-23452 but anyway it doesn't fully fix it. Also, we have another small problem which was introduced after FLINK-23452 and also led to the small drop. But in general, I think it is ok if we will take this fix.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org