You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by sr...@apache.org on 2021/04/14 20:36:49 UTC
[plc4x] branch develop updated: plc4go: enabled most of the s7
parser tests
This is an automated email from the ASF dual-hosted git repository.
sruehl pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git
The following commit(s) were added to refs/heads/develop by this push:
new 8ceab5f3 plc4go: enabled most of the s7 parser tests
8ceab5f3 is described below
commit 8ceab5f364887d20ba5fce96e9b853cdbc4be12a
Author: Sebastian Rühl <sr...@apache.org>
AuthorDate: Wed Apr 14 22:36:37 2021 +0200
plc4go: enabled most of the s7 parser tests
---
plc4go/cmd/main/drivers/tests/s7_parser_serializer_test.go | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/plc4go/cmd/main/drivers/tests/s7_parser_serializer_test.go b/plc4go/cmd/main/drivers/tests/s7_parser_serializer_test.go
index 87bac9c..5094bb3 100644
--- a/plc4go/cmd/main/drivers/tests/s7_parser_serializer_test.go
+++ b/plc4go/cmd/main/drivers/tests/s7_parser_serializer_test.go
@@ -25,7 +25,10 @@ import (
)
func TestS7ParserSerializer(t *testing.T) {
- // TODO: java serializer wrongfully adds 0x00 at the end of the messages and therefore this test fails because they are unexpected
- t.Skip("Still a work in progress")
- testutils.RunParserSerializerTestsuite(t, "assets/testing/protocols/s7/ParserSerializerTestsuite.xml")
+ testutils.RunParserSerializerTestsuite(t, "assets/testing/protocols/s7/ParserSerializerTestsuite.xml",
+ "",
+ // TODO: One byte to short
+ "S7 Read Response",
+ "S7 Write Request",
+ )
}