[GitHub] [incubator-superset] nikolagigic commented on a change in pull request #11979: fix(dataset): Page blanks on large data load

[GitBox <gi...@apache.org>]

nikolagigic commented on a change in pull request #11979:
URL: https://github.com/apache/incubator-superset/pull/11979#discussion_r543575356



##########
File path: superset-frontend/src/explore/components/DataTablesPane.tsx
##########
@@ -191,11 +196,13 @@ export const DataTablesPane = ({
       if (data[type]?.length === 0) {
         return <span>No data</span>;
       }
+      const renderWithPagination = true;
       return (
         <TableView
           columns={columns[type]}
           data={filteredData[type]}
-          withPagination={false}
+          withPagination={renderWithPagination}

Review comment:
       Lint test is going to throw: `Value must be omitted for boolean attributes`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org