You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/04/24 01:40:29 UTC
Re: Review Request 46423: Windows: Forked `subprocess.cpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46423/
-----------------------------------------------------------
(Updated April 23, 2016, 11:40 p.m.)
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Summary (updated)
-----------------
Windows: Forked `subprocess.cpp`.
Bugs: MESOS-3637
https://issues.apache.org/jira/browse/MESOS-3637
Repository: mesos
Description
-------
Windows: Forked subprocess.cpp, added `Windows` implementation.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45
3rdparty/libprocess/include/process/subprocess.hpp 6ce1a827e36e0c65985e3928c89f51561fdd70cd
3rdparty/libprocess/src/CMakeLists.txt a8379d323f30037bdd15e151957f885664b5e242
3rdparty/libprocess/src/subprocess.cpp bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3
3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION
3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/46423/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 46423: Windows: Forked `subprocess.cpp`.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46423/#review130841
-----------------------------------------------------------
3rdparty/libprocess/src/subprocess.cpp (lines 13 - 42)
<https://reviews.apache.org/r/46423/#comment194743>
It seems like most of these are no longer necessary. Can we prune this a little bit, please?
3rdparty/libprocess/src/subprocess.cpp (lines 44 - 46)
<https://reviews.apache.org/r/46423/#comment194744>
Doesn't look like we need these anymore.
3rdparty/libprocess/src/subprocess.cpp
<https://reviews.apache.org/r/46423/#comment194741>
Why didn't this comment make it over to `src/subprocess_posix.cpp`?
3rdparty/libprocess/src/subprocess.cpp (lines 56 - 71)
<https://reviews.apache.org/r/46423/#comment194740>
There's a copy of this in `src/subprocess_posix.cpp`. It seems like this was supposed to be removed?
3rdparty/libprocess/src/subprocess_windows.cpp (line 36)
<https://reviews.apache.org/r/46423/#comment194742>
This isn't used.
- Michael Park
On April 23, 2016, 11:40 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46423/
> -----------------------------------------------------------
>
> (Updated April 23, 2016, 11:40 p.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-3637
> https://issues.apache.org/jira/browse/MESOS-3637
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Forked subprocess.cpp, added `Windows` implementation.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45
> 3rdparty/libprocess/include/process/subprocess.hpp 6ce1a827e36e0c65985e3928c89f51561fdd70cd
> 3rdparty/libprocess/src/CMakeLists.txt a8379d323f30037bdd15e151957f885664b5e242
> 3rdparty/libprocess/src/subprocess.cpp bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3
> 3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION
> 3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46423/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>