You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Aleksey Shipilev (JIRA)" <ji...@apache.org> on 2008/05/28 16:31:45 UTC
[jira] Created: (HARMONY-5847) [classlib][luni][performance]
ObjectInputStream/ObjectOutputStream cleanup
[classlib][luni][performance] ObjectInputStream/ObjectOutputStream cleanup
--------------------------------------------------------------------------
Key: HARMONY-5847
URL: https://issues.apache.org/jira/browse/HARMONY-5847
Project: Harmony
Issue Type: Sub-task
Reporter: Aleksey Shipilev
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5847) [classlib][luni][performance]
ObjectInputStream/ObjectOutputStream cleanup
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603276#action_12603276 ]
Nathan Beyer commented on HARMONY-5847:
---------------------------------------
Does RC mean anything special? Not ready for prime time? I'm going to assume it's ready to go and play with it this weekend.
> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream cleanup
> --------------------------------------------------------------------------
>
> Key: HARMONY-5847
> URL: https://issues.apache.org/jira/browse/HARMONY-5847
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Aleksey Shipilev
> Assignee: Nathan Beyer
> Attachments: cl-O_IO-cleanup-rc1.patch, cl-O_IO-cleanup-rc2.patch
>
>
> This issue is dedicated for ObjectOutputStream/ObjectInputStream cleanup and optimization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5847) [classlib][luni][performance]
ObjectInputStream/ObjectOutputStream cleanup
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathan Beyer reassigned HARMONY-5847:
-------------------------------------
Assignee: Nathan Beyer
> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream cleanup
> --------------------------------------------------------------------------
>
> Key: HARMONY-5847
> URL: https://issues.apache.org/jira/browse/HARMONY-5847
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Aleksey Shipilev
> Assignee: Nathan Beyer
> Attachments: cl-O_IO-cleanup-rc1.patch
>
>
> This issue is dedicated for ObjectOutputStream/ObjectInputStream cleanup and optimization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5847) [classlib][luni][performance]
ObjectInputStream/ObjectOutputStream cleanup
Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602915#action_12602915 ]
Aleksey Shipilev commented on HARMONY-5847:
-------------------------------------------
Yes, disregard RC1, use RC2 instead.
> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream cleanup
> --------------------------------------------------------------------------
>
> Key: HARMONY-5847
> URL: https://issues.apache.org/jira/browse/HARMONY-5847
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Aleksey Shipilev
> Assignee: Nathan Beyer
> Attachments: cl-O_IO-cleanup-rc1.patch, cl-O_IO-cleanup-rc2.patch
>
>
> This issue is dedicated for ObjectOutputStream/ObjectInputStream cleanup and optimization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5847) [classlib][luni][performance]
ObjectInputStream/ObjectOutputStream cleanup
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603756#action_12603756 ]
Nathan Beyer commented on HARMONY-5847:
---------------------------------------
The cleanup patch was applied at r665952.
> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream cleanup
> --------------------------------------------------------------------------
>
> Key: HARMONY-5847
> URL: https://issues.apache.org/jira/browse/HARMONY-5847
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Aleksey Shipilev
> Assignee: Nathan Beyer
> Attachments: cl-O_IO-cleanup-minor1.patch, cl-O_IO-cleanup-rc1.patch, cl-O_IO-cleanup-rc2.patch
>
>
> This issue is dedicated for ObjectOutputStream/ObjectInputStream cleanup and optimization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5847) [classlib][luni][performance]
ObjectInputStream/ObjectOutputStream cleanup
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathan Beyer resolved HARMONY-5847.
-----------------------------------
Resolution: Fixed
I've applied the patch at r664611. Please verify it. Thanks.
> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream cleanup
> --------------------------------------------------------------------------
>
> Key: HARMONY-5847
> URL: https://issues.apache.org/jira/browse/HARMONY-5847
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Aleksey Shipilev
> Assignee: Nathan Beyer
> Attachments: cl-O_IO-cleanup-rc1.patch, cl-O_IO-cleanup-rc2.patch
>
>
> This issue is dedicated for ObjectOutputStream/ObjectInputStream cleanup and optimization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5847) [classlib][luni][performance]
ObjectInputStream/ObjectOutputStream cleanup
Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Shipilev updated HARMONY-5847:
--------------------------------------
Attachment: cl-O_IO-cleanup-rc1.patch
cl-O_IO-cleanup-rc1.patch:
Various improvements:
- cleaning up forced boxing/unboxing of ints
- merging reference update in updateReference()
- storing isSerializable, isExternalizable, isEnum, isProxy properties in OSC (eliminating native calls for DRLVM, contention, etc)
- propagating class descriptors throughout the OIS/OOS (saving the OSC.lookup()'s)
- eliminating writeClassDescForClass (lookup + writeClassDesc)
- eliminating redundant wrappers for OSC.lookupStreamClass()
LUNI tests are OK.
This patch gives significant boosts on SPECjvm2008:serial: +20% (8-core CTN), +35% (8-core HTN), +200% (16-core TGN).
> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream cleanup
> --------------------------------------------------------------------------
>
> Key: HARMONY-5847
> URL: https://issues.apache.org/jira/browse/HARMONY-5847
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Aleksey Shipilev
> Attachments: cl-O_IO-cleanup-rc1.patch
>
>
> This issue is dedicated for ObjectOutputStream/ObjectInputStream cleanup and optimization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5847) [classlib][luni][performance]
ObjectInputStream/ObjectOutputStream cleanup
Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Shipilev updated HARMONY-5847:
--------------------------------------
Attachment: cl-O_IO-cleanup-rc2.patch
cl-O_IO-cleanup-rc2.patch
Updated upon discussion on dev-list:
- inlined updateReference
- cleaned up ToDos
> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream cleanup
> --------------------------------------------------------------------------
>
> Key: HARMONY-5847
> URL: https://issues.apache.org/jira/browse/HARMONY-5847
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Aleksey Shipilev
> Assignee: Nathan Beyer
> Attachments: cl-O_IO-cleanup-rc1.patch, cl-O_IO-cleanup-rc2.patch
>
>
> This issue is dedicated for ObjectOutputStream/ObjectInputStream cleanup and optimization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5847) [classlib][luni][performance]
ObjectInputStream/ObjectOutputStream cleanup
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathan Beyer closed HARMONY-5847.
---------------------------------
> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream cleanup
> --------------------------------------------------------------------------
>
> Key: HARMONY-5847
> URL: https://issues.apache.org/jira/browse/HARMONY-5847
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Aleksey Shipilev
> Assignee: Nathan Beyer
> Attachments: cl-O_IO-cleanup-minor1.patch, cl-O_IO-cleanup-rc1.patch, cl-O_IO-cleanup-rc2.patch
>
>
> This issue is dedicated for ObjectOutputStream/ObjectInputStream cleanup and optimization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5847) [classlib][luni][performance]
ObjectInputStream/ObjectOutputStream cleanup
Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Shipilev updated HARMONY-5847:
--------------------------------------
Attachment: cl-O_IO-cleanup-minor1.patch
cl-O_IO-cleanup-minor1.patch
Cleanup after commit.
Nathan, please commit this patch too, it performs some housekeeping I forgot to do in RC2. As for performance and functional sides, there are no regressions/degradations on MTHarness and SPECjvm2008, so you may close the issue then. Thanks.
> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream cleanup
> --------------------------------------------------------------------------
>
> Key: HARMONY-5847
> URL: https://issues.apache.org/jira/browse/HARMONY-5847
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Aleksey Shipilev
> Assignee: Nathan Beyer
> Attachments: cl-O_IO-cleanup-minor1.patch, cl-O_IO-cleanup-rc1.patch, cl-O_IO-cleanup-rc2.patch
>
>
> This issue is dedicated for ObjectOutputStream/ObjectInputStream cleanup and optimization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5847) [classlib][luni][performance]
ObjectInputStream/ObjectOutputStream cleanup
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602872#action_12602872 ]
Nathan Beyer commented on HARMONY-5847:
---------------------------------------
Does the second patch replace the first?
> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream cleanup
> --------------------------------------------------------------------------
>
> Key: HARMONY-5847
> URL: https://issues.apache.org/jira/browse/HARMONY-5847
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Aleksey Shipilev
> Assignee: Nathan Beyer
> Attachments: cl-O_IO-cleanup-rc1.patch, cl-O_IO-cleanup-rc2.patch
>
>
> This issue is dedicated for ObjectOutputStream/ObjectInputStream cleanup and optimization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5847) [classlib][luni][performance]
ObjectInputStream/ObjectOutputStream cleanup
Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Shipilev updated HARMONY-5847:
--------------------------------------
Component/s: Classlib
Estimated Complexity: Moderate
Description: This issue is dedicated for ObjectOutputStream/ObjectInputStream cleanup and optimization.
Patch Info: [Patch Available]
> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream cleanup
> --------------------------------------------------------------------------
>
> Key: HARMONY-5847
> URL: https://issues.apache.org/jira/browse/HARMONY-5847
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Aleksey Shipilev
>
> This issue is dedicated for ObjectOutputStream/ObjectInputStream cleanup and optimization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5847) [classlib][luni][performance]
ObjectInputStream/ObjectOutputStream cleanup
Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603353#action_12603353 ]
Aleksey Shipilev commented on HARMONY-5847:
-------------------------------------------
It means Release Candidate or something, this patch is ready for review and commit. I usually divide the patches into "drafts" and "RCs".
> [classlib][luni][performance] ObjectInputStream/ObjectOutputStream cleanup
> --------------------------------------------------------------------------
>
> Key: HARMONY-5847
> URL: https://issues.apache.org/jira/browse/HARMONY-5847
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Aleksey Shipilev
> Assignee: Nathan Beyer
> Attachments: cl-O_IO-cleanup-rc1.patch, cl-O_IO-cleanup-rc2.patch
>
>
> This issue is dedicated for ObjectOutputStream/ObjectInputStream cleanup and optimization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.