You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2026/03/06 09:51:48 UTC

Re: [PR] [SPARK-55831][FOLLOWUP] Fix Maven CI by replacing with dummy SPARK_HOME in test [spark]

pan3793 commented on code in PR #54651:
URL: https://github.com/apache/spark/pull/54651#discussion_r2894848023


##########
.github/workflows/maven_test.yml:
##########
@@ -205,7 +205,7 @@ jobs:
           export TEST_MODULES=`echo "$MODULES_TO_TEST" | sed -e "s%#%/%g"`
           ./build/mvn $MAVEN_CLI_OPTS -DskipTests -Pyarn -Pkubernetes -Pvolcano -Phive -Phive-thriftserver -Phadoop-cloud -Pjvm-profiler -Pspark-ganglia-lgpl -Pkinesis-asl -Djava.version=${JAVA_VERSION/-ea} clean install
           
-          if [ "$MODULES_TO_TEST" != "connect" ]; then
+          if [ "$MODULES_TO_TEST" != *"hive-thriftserver"* ]; then

Review Comment:
   I switched to a simple approach that makes the test not depend on the assembly package, so we don't need to worry about this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org