You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/28 17:55:21 UTC

[jira] [Commented] (DRILL-4911) SimpleParallelizer should avoid plan serialization for logging purpose when debug logging is not enabled.

    [ https://issues.apache.org/jira/browse/DRILL-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530378#comment-15530378 ] 

ASF GitHub Bot commented on DRILL-4911:
---------------------------------------

GitHub user jinfengni opened a pull request:

    https://github.com/apache/drill/pull/599

    DRILL-4911:  Avoid plan serialization in SimpleParallelizer when debu…

    …g logging is not enabled.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jinfengni/incubator-drill DRILL-4911

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/599.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #599
    
----
commit d87a4fabf657cc8b5fbf9d2f8e5f337927f4a4b8
Author: Jinfeng Ni <jn...@apache.org>
Date:   2016-09-21T23:03:49Z

    DRILL-4911:  Avoid plan serialization in SimpleParallelizer when debug logging is not enabled.

----


> SimpleParallelizer should avoid plan serialization for logging purpose when debug logging is not enabled.
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-4911
>                 URL: https://issues.apache.org/jira/browse/DRILL-4911
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Query Planning & Optimization
>            Reporter: Jinfeng Ni
>            Priority: Minor
>
> SimpleParallelizer and subclass have code to put serialized plan in debug log. However, in case when the physical plan fragment is very large (table is huge with large # of partitions, files, etc), the overhead of serialization is not negligible. The code seems to always do serialization, regardless whether the debug flag is turned on. 
> To reduce the overhead, SimpleParallelizer and subclass should only do plan serialization for logging purpose when debug logging is turned on.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)