[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4244: Add support for custom record-readers in the create-segment tool

[GitBox <gi...@apache.org>]

sunithabeeram commented on a change in pull request #4244: Add support for custom record-readers in the create-segment tool
URL: https://github.com/apache/incubator-pinot/pull/4244#discussion_r291807150
 
 

 ##########
 File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/CreateSegmentCommand.java
 ##########
 @@ -291,7 +293,10 @@ public boolean execute()
     File[] files = dir.listFiles(new FilenameFilter() {
       @Override
       public boolean accept(File dir, String name) {
-        return name.toLowerCase().endsWith(_format.toString().toLowerCase());
+        if (_format != null) {
 
 Review comment:
   Didn't get notified about your comments on this PR :( - sorry about the delay in response.
   
   Let me check what the exception path message is to the users - if its sensible enough, I will just let it take that path instead of doing an additional validation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org