You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/02/25 14:26:52 UTC

[GitHub] [servicecomb-service-center] ChinX opened a new pull request #635: [SCB-1788] [Syncer] Change moduleServer interface definition to simplify code

ChinX opened a new pull request #635: [SCB-1788] [Syncer] Change moduleServer interface definition to simplify code
URL: https://github.com/apache/servicecomb-service-center/pull/635
 
 
   Base on PR #628
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] codecov-io edited a comment on issue #635: [SCB-1788] [Syncer] Change moduleServer interface definition to simplify code

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #635: [SCB-1788] [Syncer] Change moduleServer interface definition to simplify code
URL: https://github.com/apache/servicecomb-service-center/pull/635#issuecomment-591532154
 
 
   # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=h1) Report
   > Merging [#635](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/85dc71bdc30cb3a226170b99c98e8e3df6cc5c78?src=pr&el=desc) will **increase** coverage by `0.79%`.
   > The diff coverage is `88.31%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #635      +/-   ##
   ==========================================
   + Coverage   57.12%   57.92%   +0.79%     
   ==========================================
     Files         207      212       +5     
     Lines       16062    16208     +146     
   ==========================================
   + Hits         9175     9388     +213     
   + Misses       6220     6154      -66     
   + Partials      667      666       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [syncer/pkg/utils/atomic\_bool.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy91dGlscy9hdG9taWNfYm9vbC5nbw==) | `100% <100%> (ø)` | |
   | [syncer/task/idle/idle.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svaWRsZS9pZGxlLmdv) | `100% <100%> (ø)` | |
   | [syncer/task/task.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svdGFzay5nbw==) | `100% <100%> (ø)` | |
   | [syncer/task/ticker/ticker.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svdGlja2VyL3RpY2tlci5nbw==) | `100% <100%> (ø)` | |
   | [syncer/serf/agent.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvYWdlbnQuZ28=) | `43.95% <44.44%> (+4.16%)` | :arrow_up: |
   | [syncer/pkg/utils/addr.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy91dGlscy9hZGRyLmdv) | `56.25% <57.14%> (-7.39%)` | :arrow_down: |
   | [syncer/config/verify.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy92ZXJpZnkuZ28=) | `81.9% <81.9%> (ø)` | |
   | [syncer/config/merge.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy9tZXJnZS5nbw==) | `92.53% <92.53%> (ø)` | |
   | [syncer/config/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy9jb25maWcuZ28=) | `86.27% <93.33%> (+39.69%)` | :arrow_up: |
   | [server/handler/accesslog/handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c2VydmVyL2hhbmRsZXIvYWNjZXNzbG9nL2hhbmRsZXIuZ28=) | `29.09% <0%> (-21.82%)` | :arrow_down: |
   | ... and [19 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=footer). Last update [85dc71b...5683c66](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] coveralls commented on issue #635: [SCB-1788] [Syncer] Change moduleServer interface definition to simplify code

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #635: [SCB-1788] [Syncer] Change moduleServer interface definition to simplify code
URL: https://github.com/apache/servicecomb-service-center/pull/635#issuecomment-590939619
 
 
   
   [![Coverage Status](https://coveralls.io/builds/28950290/badge)](https://coveralls.io/builds/28950290)
   
   Coverage increased (+0.9%) to 60.576% when pulling **9d9b6cb247acaf2670bdc79d9ef23f3955c324b7 on ChinX:syncer-module** into **ab4ec2eef3ffe6a24a55e833792520cbf05cc322 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] coveralls edited a comment on issue #635: [SCB-1788] [Syncer] Change moduleServer interface definition to simplify code

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #635: [SCB-1788] [Syncer] Change moduleServer interface definition to simplify code
URL: https://github.com/apache/servicecomb-service-center/pull/635#issuecomment-590939619
 
 
   
   [![Coverage Status](https://coveralls.io/builds/28979649/badge)](https://coveralls.io/builds/28979649)
   
   Coverage increased (+0.8%) to 60.435% when pulling **5683c6671421e3b7c49ead5268f9bf54f4af1a37 on ChinX:syncer-module** into **ab4ec2eef3ffe6a24a55e833792520cbf05cc322 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] zenlint commented on issue #635: [SCB-1788] [Syncer] Change moduleServer interface definition to simplify code

Posted by GitBox <gi...@apache.org>.
zenlint commented on issue #635: [SCB-1788] [Syncer] Change moduleServer interface definition to simplify code
URL: https://github.com/apache/servicecomb-service-center/pull/635#issuecomment-603880221
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] coveralls edited a comment on issue #635: [SCB-1788] [Syncer] Change moduleServer interface definition to simplify code

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #635: [SCB-1788] [Syncer] Change moduleServer interface definition to simplify code
URL: https://github.com/apache/servicecomb-service-center/pull/635#issuecomment-590939619
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29582761/badge)](https://coveralls.io/builds/29582761)
   
   Coverage increased (+0.07%) to 60.546% when pulling **2dbeb6573dbee1f801a1e3031380ea2843ff07c5 on ChinX:syncer-module** into **dc21fb456d8fad558e60b41036336859bf4b9403 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] zenlint merged pull request #635: [SCB-1788] [Syncer] Change moduleServer interface definition to simplify code

Posted by GitBox <gi...@apache.org>.
zenlint merged pull request #635: [SCB-1788] [Syncer] Change moduleServer interface definition to simplify code
URL: https://github.com/apache/servicecomb-service-center/pull/635
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] coveralls edited a comment on issue #635: [SCB-1788] [Syncer] Change moduleServer interface definition to simplify code

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #635: [SCB-1788] [Syncer] Change moduleServer interface definition to simplify code
URL: https://github.com/apache/servicecomb-service-center/pull/635#issuecomment-590939619
 
 
   
   [![Coverage Status](https://coveralls.io/builds/28977697/badge)](https://coveralls.io/builds/28977697)
   
   Coverage increased (+0.8%) to 60.471% when pulling **b3576f7c1bedc5df47408b1bf5782be2382a889c on ChinX:syncer-module** into **ab4ec2eef3ffe6a24a55e833792520cbf05cc322 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-service-center] codecov-io commented on issue #635: [SCB-1788] [Syncer] Change moduleServer interface definition to simplify code

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #635: [SCB-1788] [Syncer] Change moduleServer interface definition to simplify code
URL: https://github.com/apache/servicecomb-service-center/pull/635#issuecomment-591532154
 
 
   # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=h1) Report
   > Merging [#635](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/85dc71bdc30cb3a226170b99c98e8e3df6cc5c78?src=pr&el=desc) will **increase** coverage by `0.88%`.
   > The diff coverage is `88.31%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #635      +/-   ##
   =========================================
   + Coverage   57.12%     58%   +0.88%     
   =========================================
     Files         207     212       +5     
     Lines       16062   16208     +146     
   =========================================
   + Hits         9175    9402     +227     
   + Misses       6220    6142      -78     
   + Partials      667     664       -3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [syncer/pkg/utils/atomic\_bool.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy91dGlscy9hdG9taWNfYm9vbC5nbw==) | `100% <100%> (ø)` | |
   | [syncer/task/idle/idle.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svaWRsZS9pZGxlLmdv) | `100% <100%> (ø)` | |
   | [syncer/task/task.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svdGFzay5nbw==) | `100% <100%> (ø)` | |
   | [syncer/task/ticker/ticker.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svdGlja2VyL3RpY2tlci5nbw==) | `100% <100%> (ø)` | |
   | [syncer/serf/agent.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL3NlcmYvYWdlbnQuZ28=) | `43.95% <44.44%> (+4.16%)` | :arrow_up: |
   | [syncer/pkg/utils/addr.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy91dGlscy9hZGRyLmdv) | `56.25% <57.14%> (-7.39%)` | :arrow_down: |
   | [syncer/config/verify.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy92ZXJpZnkuZ28=) | `81.9% <81.9%> (ø)` | |
   | [syncer/config/merge.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy9tZXJnZS5nbw==) | `92.53% <92.53%> (ø)` | |
   | [syncer/config/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy9jb25maWcuZ28=) | `86.27% <93.33%> (+39.69%)` | :arrow_up: |
   | [server/plugin/pkg/discovery/etcd/indexer\_cache.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9jYWNoZS5nbw==) | `78.94% <0%> (-9.29%)` | :arrow_down: |
   | ... and [23 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/635/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=footer). Last update [85dc71b...b3576f7](https://codecov.io/gh/apache/servicecomb-service-center/pull/635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services