[GitHub] sterlinghughes commented on a change in pull request #1559: [Do Not Merge] - Change HAL I2C driver to use TWIM+EasyDMA

[GitBox <gi...@apache.org>]

sterlinghughes commented on a change in pull request #1559: [Do Not Merge] - Change HAL I2C driver to use TWIM+EasyDMA
URL: https://github.com/apache/mynewt-core/pull/1559#discussion_r241832075
 
 

 ##########
 File path: hw/bus/include/bus/bus_driver.h
 ##########
 @@ -58,7 +58,11 @@ struct bus_dev_ops {
                  uint16_t length, os_time_t timeout, uint16_t flags);
     /* Write data to node */
     int (* write)(struct bus_dev *dev, struct bus_node *node, const uint8_t *buf,
-                  uint16_t length, os_time_t timeout,  uint16_t flags);
+                  uint16_t length, os_time_t timeout, uint16_t flags);
+    /* Write and read data to node */
+    int (* write_read)(struct bus_dev *dev, struct bus_node *node, const uint8_t *wbuf,
 
 Review comment:
   I think this should be a driver not a HAL.  I am not crazy about DMA being used within the HAL in general.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services