You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tooling.apache.org by "ottlinger (via GitHub)" <gi...@apache.org> on 2026/10/12 21:58:15 UTC
[I] Show version of RAT being used and integrate RAT into dependabot (tooling-trusted-releases)
ottlinger opened a new issue, #1725:
URL: https://github.com/apache/tooling-trusted-releases/issues/1725
As a member of the RAT PMC I had a look and the retro and wondered where the RAT version used in ATR is managed. It is part of the [Dockerfile](https://github.com/apache/tooling-trusted-releases/blob/main/Dockerfile.alpine#L53) and thus is not properly taken care of by dependabot.
As RAT does changes to its internals it might be useful to:
* extract the version of RAT and configure it in dependabot to find updates
* run some sort of integration test to make sure that RAT is still working the way ATR wants it to work.
In order to track errors more easily I (as a user of ATR) would want to see the version of RAT used somewhere, this would allow it to write a test that verifies, that RAT's report is parseable in the way the ATR wants it to be.
WDYT?
Thanks for using RAT :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Show version of RAT being used and integrate RAT into dependabot (tooling-trusted-releases)
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on issue #1725:
URL: https://github.com/apache/tooling-trusted-releases/issues/1725#issuecomment-6289594424
> In order to track errors more easily I (as a user of ATR) would want to see the version of RAT used somewhere, this would allow it to write a test that verifies, that RAT's report is parseable in the way the ATR wants it to be.
I can see whole command and params:
On release Compose -> `Show details` on source artifact, -> `Show Note` -> `Rat Check` and we have `Command`
```java -Xmx64m -XX:MaxMetaspaceSize=32m -XX:+UseSerialGC -XX:CompressedClassSpaceSize=16m -jar apache-rat-0.18.jar --output-style xml --output-file .atr-rat-report.xml --counter-max UNAPPROVED:-1 --counter-min LICENSE_CATEGORIES:0 LICENSE_NAMES:0 STANDARDS:0 --input-exclude-std MISC --input-exclude-std HIDDEN_DIR --input-exclude-std MAC --input-exclude-std MAVEN --input-exclude-std ECLIPSE --input-exclude-std IDEA --input-exclude-std GIT --input-exclude-std STANDARD_SCMS --input-exclude '**/*.bundle.js' --input-exclude '**/*.chunk.js' --input-exclude '**/*.css.map' --input-exclude '**/*.js.map' --input-exclude '**/*.min.css' --input-exclude '**/*.min.js' --input-exclude '**/*.min.map' --input-exclude .atr-rat-report.xml -- .```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Show version of RAT being used and integrate RAT into dependabot (tooling-trusted-releases)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #1725:
URL: https://github.com/apache/tooling-trusted-releases/issues/1725#issuecomment-6295792429
Superseded by #1752, #1753, #1754, #1755, and #1756.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Show version of RAT being used and integrate RAT into dependabot (tooling-trusted-releases)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp closed issue #1725: Show version of RAT being used and integrate RAT into dependabot
URL: https://github.com/apache/tooling-trusted-releases/issues/1725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Show version of RAT being used and integrate RAT into dependabot (tooling-trusted-releases)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #1725:
URL: https://github.com/apache/tooling-trusted-releases/issues/1725#issuecomment-6294184352
@ottlinger Thanks, that does indeed help. I see that `ReporterTest` validates against that schema and covers nearly everything that we read. We can therefore check in CI that the schema in the jar that we ship declares the parts that we use.
I've filed RAT-582 and RAT-583 for the other two RAT issues:
https://issues.apache.org/jira/browse/RAT-582
https://issues.apache.org/jira/browse/RAT-583
As for the ATR issues mentioned above, I will probably close the current issue and split those out into new ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Show version of RAT being used and integrate RAT into dependabot (tooling-trusted-releases)
Posted by "ottlinger (via GitHub)" <gi...@apache.org>.
ottlinger commented on issue #1725:
URL: https://github.com/apache/tooling-trusted-releases/issues/1725#issuecomment-6293751845
* There is a XSD of RAT's output available:
https://github.com/apache/creadur-rat/blob/master/apache-rat-core/src/main/resources/org/apache/rat/rat-report.xsd
not sure if that helps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Show version of RAT being used and integrate RAT into dependabot (tooling-trusted-releases)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #1725:
URL: https://github.com/apache/tooling-trusted-releases/issues/1725#issuecomment-6293263404
As a result of #1068, which was resolved on 15 Sep 2026 through b9cf2d30e643e9c91830edba9661f9f40c634d3c, we do have tracking of RAT updates in a GitHub Action, though not using Dependabot. We will be informed through an issue if an update to RAT later than that used in our `Dockerfile` is available. If the prior version of RAT is also archived at the same time, our builds will fail entirely, which will alert us.
To actually track this with Dependabot, we could add a Maven POM with the metadata of the version, which Dependabot can read, and then extract the information from that in the `Dockerfile`. This would only work for Java programs, though, and we need to track other software, so we would have to add a different dependency shim for each ecosystem. Therefore I think it's probably reasonable to stick with what we have.
For displaying the version, as @slawekjaranowski points out, there is already a hint in the Command output in that it contains `-jar apache-rat-0.18.jar`, but to be more formal about this we could extract the `version/@version` attribute from the XML output and record that in check results. I expect that this is more formality than we require in practice at this stage, during beta, though.
We would love if RAT could add some tests for the parts of it that we depend on in terms of the XML structure, and we should also certainly add better RAT CI testing to ATR. I envisage adding a tool next to our existing SBOM CI tests, and we could e.g. also add some tests that depend only on pregenerated RAT output, though we'd then have to remember to bump those on every version.
Some additional bugs that I noticed:
* We should include the version or JAR hash in the cache key of the RAT check, otherwise incrementing the version does not invalidate cached results.
* If the XML has incompatible unexpected structure, this is reported as a success instead of "failing shut" in the contemporary parlance. I think that the main danger here is the output format changing (it would only have to change a little), and us not keeping that code synchronised.
* RAT 0.18 treats `.sh` files as binary, which I had never noticed before. Also any file starting with `#!/usr/bin/env ` is treated as a shell script and therefore binary and skipped.
* RAT 0.18 uses `.*SPDX-License-Identifier:\s([A-Za-z0-9\.\-]+)` to match SPDX identifiers, which means that in cases like `GPL-3.0-only OR Apache-2.0` it only reports `GPL-3.0-only`, and incorrectly disapproves the file, and in `Apache-2.0 AND GPL-3.0-only` it does the reverse and accepts a file that it should disapprove. A parenthesized SPDX expression also breaks it; we had problems with this sort of thing in ATR too.
* ATR only extracts the first license when there are multiple licenses, which in some cases breaks the verdict in a similar way to RAT's broken verdict of SPDX expressions mentioned above, because RAT sorts by the license family ID.
* We have a badges display in ATR, but it matches on `checker.endswith("rat.check_licenses")` which is not the current checker name. Looking at the commit history, we renamed the checker 28 minutes later when we added it in March 2025.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org