[GitHub] [hudi] xiarixiaoyao commented on a diff in pull request #8397: [HUDI-6055] Fix input format for bootstrap tables

["xiarixiaoyao (via GitHub)" <gi...@apache.org>]

xiarixiaoyao commented on code in PR #8397:
URL: https://github.com/apache/hudi/pull/8397#discussion_r1185993071


##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/SchemaEvolutionContext.java:
##########
@@ -82,32 +81,25 @@ public class SchemaEvolutionContext {
 
   private final InputSplit split;
   private final JobConf job;
-  private HoodieTableMetaClient metaClient;
+  private final HoodieTableMetaClient metaClient;
   public Option<InternalSchema> internalSchemaOption;
 
-  public SchemaEvolutionContext(InputSplit split, JobConf job) throws IOException {
+  public SchemaEvolutionContext(InputSplit split, JobConf job) {
     this(split, job, Option.empty());
   }
 
-  public SchemaEvolutionContext(InputSplit split, JobConf job, Option<HoodieTableMetaClient> metaClientOption) throws IOException {
+  public SchemaEvolutionContext(InputSplit split, JobConf job, Option<HoodieTableMetaClient> metaClientOption) {
     this.split = split;
     this.job = job;
     this.metaClient = metaClientOption.isPresent() ? metaClientOption.get() : setUpHoodieTableMetaClient();

Review Comment:
   now the init of internalSchemaOption has been removed.
   https://github.com/apache/hudi/blob/83d4fe15b4f50a58e919390217b71bb95e952085/hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/AbstractRealtimeRecordReader.java#L91  need to modify
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org