You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/13 08:30:41 UTC

[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #15638: [fix][test] Fix CoordinatorService, MetadataStore and MockZooKeeper leaks in tests

nicoloboschi commented on code in PR #15638:
URL: https://github.com/apache/pulsar/pull/15638#discussion_r919799930


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java:
##########
@@ -249,20 +252,14 @@ public void setup() throws Exception {
 
     @AfterMethod(alwaysRun = true)
     public void teardown() throws Exception {
-        metadataStore.close();

Review Comment:
   yes it's intentional. `store` is created by `PersistentTopicTest`. `metadataStore` is handled by the superclass `MockedBookKeeperTestCase`. So before the `store` was never closed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org