You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2024/11/23 16:39:41 UTC

(groovy) branch master updated: Trivial refactoring: extract constants

This is an automated email from the ASF dual-hosted git repository.

sunlan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git


The following commit(s) were added to refs/heads/master by this push:
     new 86b327abb2 Trivial refactoring: extract constants
86b327abb2 is described below

commit 86b327abb2ea4e751bca7f996a57aea1c0f5ad3c
Author: Daniel Sun <su...@apache.org>
AuthorDate: Sun Nov 24 00:38:39 2024 +0800

    Trivial refactoring: extract constants
---
 src/main/java/org/codehaus/groovy/classgen/Verifier.java | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/codehaus/groovy/classgen/Verifier.java b/src/main/java/org/codehaus/groovy/classgen/Verifier.java
index 93b766ffbb..f7aeb501f2 100644
--- a/src/main/java/org/codehaus/groovy/classgen/Verifier.java
+++ b/src/main/java/org/codehaus/groovy/classgen/Verifier.java
@@ -156,6 +156,8 @@ public class Verifier implements GroovyClassVisitor, Opcodes {
     private static final ClassNode GENERATED_ANNOTATION = ClassHelper.make(Generated.class);
     private static final ClassNode INTERNAL_ANNOTATION  = ClassHelper.make(Internal .class);
     private static final ClassNode TRANSIENT_ANNOTATION = ClassHelper.make(Transient.class);
+    private static final ClassNode POJO_ANNOTATION = ClassHelper.make(POJO.class);
+    private static final ClassNode COMPILESTATIC_ANNOTATION = ClassHelper.make(CompileStatic.class);
 
     // NOTE: timeStamp constants shouldn't belong to Verifier but kept here for binary compatibility
     public static final String __TIMESTAMP = "__timeStamp";
@@ -251,8 +253,7 @@ public class Verifier implements GroovyClassVisitor, Opcodes {
         addDefaultParameterMethods(node);
         addDefaultParameterConstructors(node);
 
-        boolean skipGroovify = hasAnnotation(node, ClassHelper.make(POJO.class))
-                    && hasAnnotation(node, ClassHelper.make(CompileStatic.class));
+        boolean skipGroovify = hasAnnotation(node, POJO_ANNOTATION) && hasAnnotation(node, COMPILESTATIC_ANNOTATION);
         if (!skipGroovify) {
             String classInternalName = BytecodeHelper.getClassInternalName(node);