You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/01/05 20:04:20 UTC

Review Request 55226: Cleaned up std::string usage in libprocess.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55226/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

Avoid redundant initialization to empty string, use `char` overloads
instead for single-character string literals.

Spotted with clang-tidy.


Diffs
-----

  3rdparty/libprocess/src/http.cpp 97d1424be20e217401519c2bee79857bcf087023 
  3rdparty/libprocess/src/tests/io_tests.cpp b9825e8633f64c23e4b1ea904537cdc8da64ed5b 

Diff: https://reviews.apache.org/r/55226/diff/


Testing
-------

`make check` on OSX and Linux, plus internal CI.


Thanks,

Neil Conway

Re: Review Request 55226: Cleaned up std::string usage in libprocess.

Posted by Michael Park <mp...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55226/#review160984
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Jan. 5, 2017, 12:04 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55226/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2017, 12:04 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Avoid redundant initialization to empty string, use `char` overloads
> instead for single-character string literals.
> 
> Spotted with clang-tidy.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/http.cpp 97d1424be20e217401519c2bee79857bcf087023 
>   3rdparty/libprocess/src/tests/io_tests.cpp b9825e8633f64c23e4b1ea904537cdc8da64ed5b 
> 
> Diff: https://reviews.apache.org/r/55226/diff/
> 
> 
> Testing
> -------
> 
> `make check` on OSX and Linux, plus internal CI.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>