You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "samueleresca (via GitHub)" <gi...@apache.org> on 2023/04/27 11:29:32 UTC
[GitHub] [incubator-pekko] samueleresca opened a new pull request, #302: Fixing #246: update signature and fiddle properties in project/Paradox.scala
samueleresca opened a new pull request, #302:
URL: https://github.com/apache/incubator-pekko/pull/302
Fix issue #246
- The `Paradox.scala` props have been updated to pekko value.
- The `scalafiddle.js` has been reverted to `org.akka-js`. Akka.js is distributed under [Scala LICENSE](https://www.scala-lang.org/license/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #302: Fixing #246: update signature and fiddle properties in project/Paradox.scala
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #302:
URL: https://github.com/apache/incubator-pekko/pull/302#issuecomment-1525645273
Thanks @samueleresca - seems like getting rid of the fiddle and signature stuff is best
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #302: Fixing #246: update signature and fiddle properties in project/Paradox.scala
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #302:
URL: https://github.com/apache/incubator-pekko/pull/302#issuecomment-1525551910
I'm not sure how to proceed with this.
I've never used Scala Fiddle. https://scalafiddle.io/ seems to be broken. It's possible that we might be better off removing the scalafiddle stuff in the pekko docs and just presenting the sample code as something that the user needs to work out how to run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] samueleresca commented on pull request #302: Fixing #246: update signature and fiddle properties in project/Paradox.scala
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on PR #302:
URL: https://github.com/apache/incubator-pekko/pull/302#issuecomment-1525634585
> I'm not sure how to proceed with this.
>
> I've never used Scala Fiddle. https://scalafiddle.io/ seems to be broken. It's possible that we might be better off removing the scalafiddle stuff in the pekko docs and just presenting the sample code as something that the user needs to work out how to run.
Yes, Scalafiddle seems unresponsive (see https://github.com/scala/scala-lang/issues/1295) I can proceed by removing the snippet entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning merged pull request #302: Fixing #246: update signature and fiddle properties in project/Paradox.scala
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #302:
URL: https://github.com/apache/incubator-pekko/pull/302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] samueleresca commented on pull request #302: Fixing #246: update signature and fiddle properties in project/Paradox.scala
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on PR #302:
URL: https://github.com/apache/incubator-pekko/pull/302#issuecomment-1525639732
Also, regarding the `@@signature` placeholder:
- The only place it is used is in the `mergePrioritizedN.md` file
- The `mergePrioritizedN.md` Signature subheading is broken and pointing to the wrong Source path
I think this might be replaced with the @apidoc similar to the [mergePrioritized.md#Signature](https://github.com/apache/incubator-pekko/blob/main/docs/src/main/paradox/stream/operators/Source-or-Flow/mergePrioritized.md#signature)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org