You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2020/02/13 03:50:28 UTC

svn commit: r1873965 - in /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation: PDAnnotationMarkup.java PDAnnotationTextMarkup.java

Author: tilman
Date: Thu Feb 13 03:50:28 2020
New Revision: 1873965

URL: http://svn.apache.org/viewvc?rev=1873965&view=rev
Log:
PDFBOX-4772: pass PDDocument to construct appearances, as suggested by Ghenadii Batalski

Modified:
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationMarkup.java
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationTextMarkup.java

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationMarkup.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationMarkup.java?rev=1873965&r1=1873964&r2=1873965&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationMarkup.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationMarkup.java Thu Feb 13 03:50:28 2020
@@ -869,27 +869,27 @@ public class PDAnnotationMarkup extends
             PDAppearanceHandler appearanceHandler = null;
             if (SUB_TYPE_CARET.equals(getSubtype()))
             {
-                appearanceHandler = new PDCaretAppearanceHandler(this);
+                appearanceHandler = new PDCaretAppearanceHandler(this, document);
             }
             else if (SUB_TYPE_FREETEXT.equals(getSubtype()))
             {
-                appearanceHandler = new PDFreeTextAppearanceHandler(this);
+                appearanceHandler = new PDFreeTextAppearanceHandler(this, document);
             }
             else if (SUB_TYPE_INK.equals(getSubtype()))
             {
-                appearanceHandler = new PDInkAppearanceHandler(this);
+                appearanceHandler = new PDInkAppearanceHandler(this, document);
             }
             else if (SUB_TYPE_POLYGON.equals(getSubtype()))
             {
-                appearanceHandler = new PDPolygonAppearanceHandler(this);
+                appearanceHandler = new PDPolygonAppearanceHandler(this, document);
             }
             else if (SUB_TYPE_POLYLINE.equals(getSubtype()))
             {
-                appearanceHandler = new PDPolylineAppearanceHandler(this);
+                appearanceHandler = new PDPolylineAppearanceHandler(this, document);
             }
             else if (SUB_TYPE_SOUND.equals(getSubtype()))
             {
-                appearanceHandler = new PDSoundAppearanceHandler(this);
+                appearanceHandler = new PDSoundAppearanceHandler(this, document);
             }
 
             if (appearanceHandler != null)

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationTextMarkup.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationTextMarkup.java?rev=1873965&r1=1873964&r2=1873965&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationTextMarkup.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/annotation/PDAnnotationTextMarkup.java Thu Feb 13 03:50:28 2020
@@ -131,11 +131,12 @@ public class PDAnnotationTextMarkup exte
         return getCOSObject().getNameAsString(COSName.SUBTYPE);
     }
 
-        /**
+    /**
      * Set a custom appearance handler for generating the annotations appearance streams.
-     * 
+     *
      * @param appearanceHandler
      */
+    @Override
     public void setCustomAppearanceHandler(PDAppearanceHandler appearanceHandler)
     {
         customAppearanceHandler = appearanceHandler;
@@ -155,19 +156,19 @@ public class PDAnnotationTextMarkup exte
             PDAppearanceHandler appearanceHandler = null;
             if (SUB_TYPE_HIGHLIGHT.equals(getSubtype()))
             {
-                appearanceHandler = new PDHighlightAppearanceHandler(this);
+                appearanceHandler = new PDHighlightAppearanceHandler(this, document);
             }
-            else if  (SUB_TYPE_SQUIGGLY.equals(getSubtype()))
+            else if (SUB_TYPE_SQUIGGLY.equals(getSubtype()))
             {
-                appearanceHandler = new PDSquigglyAppearanceHandler(this);
+                appearanceHandler = new PDSquigglyAppearanceHandler(this, document);
             }
-            else if  (SUB_TYPE_STRIKEOUT.equals(getSubtype()))
+            else if (SUB_TYPE_STRIKEOUT.equals(getSubtype()))
             {
-                appearanceHandler = new PDStrikeoutAppearanceHandler(this);
+                appearanceHandler = new PDStrikeoutAppearanceHandler(this, document);
             }
-            else if  (SUB_TYPE_UNDERLINE.equals(getSubtype()))
+            else if (SUB_TYPE_UNDERLINE.equals(getSubtype()))
             {
-                appearanceHandler = new PDUnderlineAppearanceHandler(this);
+                appearanceHandler = new PDUnderlineAppearanceHandler(this, document);
             }
 
             if (appearanceHandler != null)