You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by el...@apache.org on 2016/12/17 09:21:58 UTC
svn commit: r1774727 - in
/directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model:
exception/ filter/ ldif/ message/controls/
Author: elecharny
Date: Sat Dec 17 09:21:58 2016
New Revision: 1774727
URL: http://svn.apache.org/viewvc?rev=1774727&view=rev
Log:
Fixed sonarlint warnings
Modified:
directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/exception/AbstractLdapReferralException.java
directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/filter/FilterParser.java
directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/ldif/LdifRevertor.java
directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/EntryChangeImpl.java
directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/PagedResultsImpl.java
directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/SortRequestControlImpl.java
directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/SortResponseControlImpl.java
directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/SortResultCode.java
Modified: directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/exception/AbstractLdapReferralException.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/exception/AbstractLdapReferralException.java?rev=1774727&r1=1774726&r2=1774727&view=diff
==============================================================================
--- directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/exception/AbstractLdapReferralException.java (original)
+++ directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/exception/AbstractLdapReferralException.java Sat Dec 17 09:21:58 2016
@@ -86,6 +86,7 @@ public class AbstractLdapReferralExcepti
/**
* Not yet implemented
+ *
* @param arg The arguments
* @return The referral context
* @throws NamingException If the operation failed
Modified: directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/filter/FilterParser.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/filter/FilterParser.java?rev=1774727&r1=1774726&r2=1774727&view=diff
==============================================================================
--- directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/filter/FilterParser.java (original)
+++ directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/filter/FilterParser.java Sat Dec 17 09:21:58 2016
@@ -59,7 +59,7 @@ public final class FilterParser
private static ExprNode parseExtensible( SchemaManager schemaManager, String attribute, byte[] filter,
Position pos, boolean relaxed ) throws LdapException, ParseException
{
- ExtensibleNode node = null;
+ ExtensibleNode node;
if ( schemaManager != null )
{
@@ -443,7 +443,7 @@ public final class FilterParser
if ( Strings.isCharASCII( filter, pos.start, '*' ) )
{
// We have found a '*' : this is a substring
- SubstringNode node = null;
+ SubstringNode node;
if ( schemaManager != null )
{
@@ -656,7 +656,7 @@ public final class FilterParser
private static ExprNode parseItem( SchemaManager schemaManager, byte[] filter, Position pos, byte b,
boolean relaxed ) throws ParseException, LdapException
{
- String attribute = null;
+ String attribute;
if ( b == '\0' )
{
@@ -873,7 +873,7 @@ public final class FilterParser
private static ExprNode parseFilterComp( SchemaManager schemaManager, byte[] filter, Position pos,
boolean relaxed ) throws ParseException, LdapException
{
- ExprNode node = null;
+ ExprNode node;
if ( pos.start == pos.length )
{
Modified: directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/ldif/LdifRevertor.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/ldif/LdifRevertor.java?rev=1774727&r1=1774726&r2=1774727&view=diff
==============================================================================
--- directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/ldif/LdifRevertor.java (original)
+++ directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/ldif/LdifRevertor.java Sat Dec 17 09:21:58 2016
@@ -265,9 +265,9 @@ public final class LdifRevertor
public static LdifEntry reverseMove( Dn newSuperiorDn, Dn modifiedDn ) throws LdapException
{
LdifEntry entry = new LdifEntry();
- Dn currentParent = null;
- Rdn currentRdn = null;
- Dn newDn = null;
+ Dn currentParent;
+ Rdn currentRdn;
+ Dn newDn;
if ( newSuperiorDn == null )
{
@@ -445,7 +445,7 @@ public final class LdifRevertor
throws LdapInvalidDnException
{
Dn parentDn = entry.getDn();
- Dn newDn = null;
+ Dn newDn;
if ( newRdn == null )
{
@@ -470,7 +470,7 @@ public final class LdifRevertor
newDn = newDn.add( newRdn );
List<LdifEntry> entries = new ArrayList<>( 1 );
- LdifEntry reverted = new LdifEntry();
+ LdifEntry reverted;
// Start with the cases here
if ( newRdn.size() == 1 )
Modified: directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/EntryChangeImpl.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/EntryChangeImpl.java?rev=1774727&r1=1774726&r2=1774727&view=diff
==============================================================================
--- directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/EntryChangeImpl.java (original)
+++ directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/EntryChangeImpl.java Sat Dec 17 09:21:58 2016
@@ -50,6 +50,9 @@ public class EntryChangeImpl extends Abs
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public ChangeType getChangeType()
{
@@ -57,6 +60,9 @@ public class EntryChangeImpl extends Abs
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public void setChangeType( ChangeType changeType )
{
@@ -64,6 +70,9 @@ public class EntryChangeImpl extends Abs
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public Dn getPreviousDn()
{
@@ -71,6 +80,9 @@ public class EntryChangeImpl extends Abs
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public void setPreviousDn( Dn previousDn )
{
@@ -78,6 +90,9 @@ public class EntryChangeImpl extends Abs
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public long getChangeNumber()
{
@@ -85,6 +100,9 @@ public class EntryChangeImpl extends Abs
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public void setChangeNumber( long changeNumber )
{
Modified: directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/PagedResultsImpl.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/PagedResultsImpl.java?rev=1774727&r1=1774726&r2=1774727&view=diff
==============================================================================
--- directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/PagedResultsImpl.java (original)
+++ directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/PagedResultsImpl.java Sat Dec 17 09:21:58 2016
@@ -74,6 +74,9 @@ public class PagedResultsImpl extends Ab
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public int getSize()
{
@@ -81,6 +84,9 @@ public class PagedResultsImpl extends Ab
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public void setSize( int size )
{
@@ -88,6 +94,9 @@ public class PagedResultsImpl extends Ab
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public byte[] getCookie()
{
@@ -95,6 +104,9 @@ public class PagedResultsImpl extends Ab
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public void setCookie( byte[] cookie )
{
@@ -102,6 +114,9 @@ public class PagedResultsImpl extends Ab
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public int getCookieValue()
{
Modified: directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/SortRequestControlImpl.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/SortRequestControlImpl.java?rev=1774727&r1=1774726&r2=1774727&view=diff
==============================================================================
--- directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/SortRequestControlImpl.java (original)
+++ directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/SortRequestControlImpl.java Sat Dec 17 09:21:58 2016
@@ -66,6 +66,9 @@ public class SortRequestControlImpl exte
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public void addSortKey( SortKey skey )
{
@@ -78,6 +81,9 @@ public class SortRequestControlImpl exte
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public String toString()
{
Modified: directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/SortResponseControlImpl.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/SortResponseControlImpl.java?rev=1774727&r1=1774726&r2=1774727&view=diff
==============================================================================
--- directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/SortResponseControlImpl.java (original)
+++ directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/SortResponseControlImpl.java Sat Dec 17 09:21:58 2016
@@ -40,30 +40,45 @@ public class SortResponseControlImpl ext
super( OID );
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public void setSortResult( SortResultCode result )
{
this.result = result;
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public SortResultCode getSortResult()
{
return result;
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public void setAttributeName( String attributeName )
{
this.attributeName = attributeName;
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public String getAttributeName()
{
return attributeName;
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public int hashCode()
{
@@ -75,6 +90,9 @@ public class SortResponseControlImpl ext
return hash;
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public boolean equals( Object o )
{
@@ -102,6 +120,9 @@ public class SortResponseControlImpl ext
return false;
}
+ /**
+ * {@inheritDoc}
+ */
@Override
public String toString()
{
Modified: directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/SortResultCode.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/SortResultCode.java?rev=1774727&r1=1774726&r2=1774727&view=diff
==============================================================================
--- directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/SortResultCode.java (original)
+++ directory/shared/trunk/ldap/model/src/main/java/org/apache/directory/api/ldap/model/message/controls/SortResultCode.java Sat Dec 17 09:21:58 2016
@@ -66,6 +66,7 @@ public enum SortResultCode
return val;
}
+
/**
* returns the enum value representing the given code.
*