You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sentry.apache.org by Colin Ma <ju...@intel.com> on 2014/11/24 03:33:30 UTC

Review Request 28376: SENTRY-422: The URI object handling needs to be more robust

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28376/
-----------------------------------------------------------

Review request for sentry, Arun Suresh, Lenni Kuff, and Prasad Mujumdar.


Repository: sentry


Description
-------

The URI comparison is dependent on filesystem context. Currently it's required by the caller to set the right context when URI object is created. This is prone to errors and hard to catch in the unit tests.
We should refactor the AccessURI handling to make it more robust.


Diffs
-----

  sentry-core/sentry-core-model-db/pom.xml 9cfe3df 
  sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/AccessURI.java 8e44026 
  sentry-core/sentry-core-model-db/src/test/java/org/apache/sentry/core/db/TestURI.java 3b2aa31 

Diff: https://reviews.apache.org/r/28376/diff/


Testing
-------


Thanks,

Colin Ma