You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/25 06:38:26 UTC
[GitHub] [airflow] msumit opened a new pull request #16650: Fix TI success confirm page
msumit opened a new pull request #16650:
URL: https://github.com/apache/airflow/pull/16650
On TI success/failed confirm page, we were considering only params for failed ones. This bug would cause wrong info being displayed on UI (for success) while upon hitting the submit button it would mark the correct number of TIs.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #16650: Fix TI success confirm page
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #16650:
URL: https://github.com/apache/airflow/pull/16650#issuecomment-868289735
Should we just unify the field names to `upstream`, `downstream`, `future`, `past` instead? It seems qutie weird to me different `Airflow.confirm` forms are using different field names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] msumit commented on pull request #16650: Fix TI success confirm page
Posted by GitBox <gi...@apache.org>.
msumit commented on pull request #16650:
URL: https://github.com/apache/airflow/pull/16650#issuecomment-868462163
@uranusjr unified the input names.. also for other endpoints like `clear` also same input names are being used, so it makes more sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #16650: Fix TI success confirm page
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #16650:
URL: https://github.com/apache/airflow/pull/16650#issuecomment-868331053
Those field names aren’t used in JS, I think the JS code either uses a loop or get the form as a whole when submitting (I’m not very familiar with the JS code base and could be wrong). I searched the code base and all the eight names appear in exactly two places, one in HTML and one in this function. (Also `Airflow.failed` doesn’t seem to be used anywhere, but that’s another issue.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16650: Fix TI success confirm page
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16650:
URL: https://github.com/apache/airflow/pull/16650#issuecomment-869350304
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] msumit commented on pull request #16650: Fix TI success confirm page
Posted by GitBox <gi...@apache.org>.
msumit commented on pull request #16650:
URL: https://github.com/apache/airflow/pull/16650#issuecomment-868322040
@uranusjr we could, but it's just that we would need changes at many places, like JS, views & forms.. so for now, this seems an easy fix..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] msumit merged pull request #16650: Fix TI success confirm page
Posted by GitBox <gi...@apache.org>.
msumit merged pull request #16650:
URL: https://github.com/apache/airflow/pull/16650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org