You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/02/19 09:06:28 UTC
Review Request 18263: Used EXPECT_SOME_EQ in log tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18263/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Jie Yu.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
Diff: https://reviews.apache.org/r/18263/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 18263: Used EXPECT_SOME_EQ in log tests.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18263/#review35332
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 19, 2014, 8:06 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18263/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 8:06 a.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
>
> Diff: https://reviews.apache.org/r/18263/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 18263: Used EXPECT_SOME_EQ in log tests.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Feb. 19, 2014, 6:15 p.m., Ben Mahler wrote:
> > src/tests/log_tests.cpp, lines 402-403
> > <https://reviews.apache.org/r/18263/diff/1/?file=497569#file497569line402>
> >
> > You could actually squash these three lines into one for nearly all of these:
> >
> > {
> > AWAIT_EXPECT_EQ(0u, coord.elect());
> > }
> >
This actually requires some more overloads for checking equality of an Option and some value so I'm going to skip for now.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18263/#review34883
-----------------------------------------------------------
On Feb. 19, 2014, 8:06 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18263/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 8:06 a.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
>
> Diff: https://reviews.apache.org/r/18263/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 18263: Used EXPECT_SOME_EQ in log tests.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18263/#review34883
-----------------------------------------------------------
Ship it!
src/tests/log_tests.cpp
<https://reviews.apache.org/r/18263/#comment65263>
You could actually squash these three lines into one for nearly all of these:
{
AWAIT_EXPECT_EQ(0u, coord.elect());
}
- Ben Mahler
On Feb. 19, 2014, 8:06 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18263/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 8:06 a.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
>
> Diff: https://reviews.apache.org/r/18263/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 18263: Used EXPECT_SOME_EQ in log tests.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18263/#review34873
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On Feb. 19, 2014, 12:06 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18263/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 12:06 a.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
>
> Diff: https://reviews.apache.org/r/18263/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>