[qpid-proton] branch master updated: NO-JIRA: Fix github action to fail if ctest fails - Also remove unnecessary ${{ }} evaluations inside if

[as...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

astitcher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/qpid-proton.git


The following commit(s) were added to refs/heads/master by this push:
     new 692bcef  NO-JIRA: Fix github action to fail if ctest fails - Also remove unnecessary ${{ }} evaluations inside if
692bcef is described below

commit 692bcef3205ba5c171c1d2bfdda441b77d7aac05
Author: Andrew Stitcher <as...@apache.org>
AuthorDate: Thu Sep 10 18:06:18 2020 -0400

    NO-JIRA: Fix github action to fail if ctest fails
    - Also remove unnecessary ${{ }} evaluations inside if
---
 .github/workflows/build.yml | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index d869f1d..a6c8cfd 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -38,17 +38,17 @@ jobs:
         python -m pip install --upgrade pip
         python -m pip install setuptools wheel tox unittest2
     - name: Install Linux dependencies
-      if: ${{ runner.os == 'Linux' }}
+      if: runner.os == 'Linux'
       run: |
         sudo apt install -y swig libpython3-dev libsasl2-dev libjsoncpp-dev
     - name: Install Windows dependencies
-      if: ${{ runner.os == 'Windows' }}
+      if: runner.os == 'Windows'
       run: |
         choco install -y swig --version=4.0.1
         vcpkg install jsoncpp
         vcpkg integrate install
     - name: Install MacOS dependencies
-      if: ${{ runner.os == 'macOS' }}
+      if: runner.os == 'macOS'
       run: |
         brew install libuv swig pkgconfig jsoncpp
     - name: cmake configure
@@ -68,12 +68,13 @@ jobs:
       with:
         name: python-pkgs
         path: ${{env.BuildDir}}/python/pkgs
-    - name: ctest
-      continue-on-error: true
+    - id: ctest
+      name: ctest
       working-directory: ${{env.BuildDir}}
       run: ctest -C ${BuildType} -V -T Test --no-compress-output
       shell: bash
     - name: Upload Test results
+      if: always() && (steps.ctest.outcome == 'failure' || steps.ctest.outcome == 'success')
       uses: actions/upload-artifact@v2
       with:
         name: Test_Results_${{matrix.os}}_${{matrix.buildType}}
@@ -87,10 +88,10 @@ jobs:
           ${{env.BuildDir}}/c
           ${{env.BuildDir}}/python
     - name: Environment (Linux/Windows)
-      if: ${{ always() && runner.os != 'macOS' }}
+      if: always() && runner.os != 'macOS'
       run: env -0 | sort -z | tr '\0' '\n'
       shell: bash
     - name: Environment (macOS)
-      if: ${{ always() && runner.os == 'macOS' }}
+      if: always() && runner.os == 'macOS'
       run: env | sort
       shell: bash


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org