[GitHub] mike-tutkowski commented on a change in pull request #2503: Support multiple volume access groups per compute cluster

[GitBox <gi...@apache.org>]

mike-tutkowski commented on a change in pull request #2503: Support multiple volume access groups per compute cluster
URL: https://github.com/apache/cloudstack/pull/2503#discussion_r185142537
 
 

 ##########
 File path: plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/util/SolidFireUtil.java
 ##########
 @@ -300,7 +311,7 @@ public static String getValue(String keyToMatch, String url, boolean throwExcept
     }
 
     public static String getSolidFireAccountName(String csAccountUuid, long csAccountId) {
-        return "CloudStack_" + csAccountUuid + "_" + csAccountId;
+        return SF_CS_ACCOUNT_PREFIX + csAccountUuid + "_" + csAccountId;
 
 Review comment:
   Correct, it just gives you the name of the SolidFire account that corresponds to the applicable CloudStack account. Maybe a better name is getCorrespondingSolidFireAccountName? I could change the implementation to accept an Account and then just pull out of the Account object what I need (UUID and ID) to create the name of the SolidFire account.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services