[GitHub] [calcite] amaliujia commented on a change in pull request #1642: [CALCITE-3583] Support serialized to json and deserialized from json for Exchange relation operator

[GitBox <gi...@apache.org>]

amaliujia commented on a change in pull request #1642: [CALCITE-3583] Support serialized to json and deserialized from json for Exchange relation operator
URL: https://github.com/apache/calcite/pull/1642#discussion_r356282226
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java
 ##########
 @@ -191,7 +191,10 @@ public RelFieldCollation toFieldCollation(Map<String, Object> map) {
   }
 
   public RelDistribution toDistribution(Object o) {
-    return RelDistributions.ANY; // TODO:
+    final Map map = (Map) o;
 
 Review comment:
   Is there a need to check if Object is a Map?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services