You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Denis Magda <dm...@gridgain.com> on 2016/03/02 10:33:20 UTC
Contributions that are waiting for review
Ignite committers,
There is a number of contributions that have to be reviewed.
Please pick them up basing on your experience and provide your review notes.
Ignite 2718: Missing ZookeeperIpFinder dependencies
<https://issues.apache.org/jira/browse/IGNITE-2718>
IGNITE-2693: withKeepBinary and non-binary marshallers
<https://issues.apache.org/jira/browse/IGNITE-2693>
IGNITE-2735: Fixes distributed semaphore local node stopping issue.
<https://issues.apache.org/jira/browse/IGNITE-2735>
*IGNITE-642: Implements cache distributed reentrant lock
<https://issues.apache.org/jira/browse/IGNITE-642>
*Regards,
Denis
Re: Contributions that are waiting for review
Posted by Denis Magda <dm...@gridgain.com>.
Roman,
Please send the message directly to the dev list when you need a review.
Quite often people who open an issue are not eligible for review and
thus don't provide any feedback.
Regards,
Denis
On 3/2/2016 4:08 PM, Roman Shtykh wrote:
> I have also asked for review of the following tickets but failed to get a feedback.
> They are not complicated, but I would appreciate a quick review. Thank you!
>
> [IGNITE-2563] Queries: ArrayIndexOutOfBoundsException when using BOOL_AND
>
> https://issues.apache.org/jira/browse/IGNITE-2563
>
> IGNITE-2416 TcpDiscoverySharedFsIpFinder doesn't work with IPv6 addresses
> https://issues.apache.org/jira/browse/IGNITE-2416
>
> and a new one
>
> IGNITE-2710 Session not unbind from current request after invoking request.getSession().invalidate()
> https://issues.apache.org/jira/browse/IGNITE-2710
>
> -Roman
>
>
> On Wednesday, March 2, 2016 6:38 PM, Denis Magda <dm...@gridgain.com> wrote:
>
>
>
> Ignite committers,
>
> There is a number of contributions that have to be reviewed.
>
> Please pick them up basing on your experience and provide your review notes.
>
> Ignite 2718: Missing ZookeeperIpFinder dependencies
> <https://issues.apache.org/jira/browse/IGNITE-2718>
> IGNITE-2693: withKeepBinary and non-binary marshallers
> <https://issues.apache.org/jira/browse/IGNITE-2693>
> IGNITE-2735: Fixes distributed semaphore local node stopping issue.
> <https://issues.apache.org/jira/browse/IGNITE-2735>
> *IGNITE-642: Implements cache distributed reentrant lock
> <https://issues.apache.org/jira/browse/IGNITE-642>
>
>
> *Regards,
> Denis
Re: Contributions that are waiting for review
Posted by Denis Magda <dm...@gridgain.com>.
Looks great, thanks!
On 3/17/2016 3:55 PM, Anton Vinogradov wrote:
> Done,
>
> https://cwiki.apache.org/confluence/display/IGNITE/Issues+waiting+for+review
>
> On Thu, Mar 17, 2016 at 3:46 PM, Denis Magda <dm...@gridgain.com> wrote:
>
>> Pavel, Anton,
>>
>> Can we simply create a page on Apache wiki that will show a result of the
>> specific JIRA filter execution? This can be the first improvement we can do
>> in this direction.
>>
>> --
>> Denis
>>
>>
>> On 3/4/2016 4:14 PM, Anton Vinogradov wrote:
>>
>>> Pavel,
>>> I think that script should be stored inside TeamCity task.
>>>
>>>
>>>
>>> On Fri, Mar 4, 2016 at 3:56 PM, Pavel Tupitsyn <pt...@gridgain.com>
>>> wrote:
>>>
>>> Anton, good idea, the script can be stored in git this way. Dmitriy, what
>>>> do you think?
>>>>
>>>> Another question is the email account to send from. Do we have something
>>>> suitable already?
>>>>
>>>>
>>>>
>>>> On Fri, Mar 4, 2016 at 3:34 PM, Anton Vinogradov <
>>>> avinogradov@gridgain.com
>>>> wrote:
>>>>
>>>> Folks,
>>>>> we can create TeamCity task with special trigger (eg. once a day).
>>>>> This task can contains any script.
>>>>>
>>>>> On Fri, Mar 4, 2016 at 3:18 PM, Pavel Tupitsyn <pt...@gridgain.com>
>>>>> wrote:
>>>>>
>>>>> Raul, I'm not good with shell scripts. As a .net person I was thinking
>>>>>> about a scheduled C# script on one of our TeamCity win machines, but
>>>>>>
>>>>> Dmitry
>>>>>
>>>>>> prefers Jenkins.
>>>>>>
>>>>>>
>>>>>> On Fri, Mar 4, 2016 at 2:52 PM, Raul Kripalani <ra...@apache.org>
>>>>>>
>>>>> wrote:
>>>>> I believe all we need is a shell script in our source tree that
>>>>>> queries
>>>>> the
>>>>>>> JIRA API and produces an output on stdout.
>>>>>>>
>>>>>>> We can then schedule an overnight job with, e.g. a 0 23 * * * cron
>>>>>>> expression, and configure the output to be sent to the ML, as
>>>>>>>
>>>>>> indicated
>>>>> here: https://wiki.apache.org/general/Jenkins.
>>>>>>> @Pavel, would you like to work on the shell script? I can help you
>>>>>>> configure the JKS job.
>>>>>>>
>>>>>>> @Dmitriy, can you add both Pavel and me as job admins?
>>>>>>>
>>>>>>>
>>>>>>>
>>>> https://wiki.apache.org/general/Jenkins?action=show&redirect=Hudson#How_do_I_get_an_account
>>>>
>>>>> Cheers,
>>>>>>>
Re: Contributions that are waiting for review
Posted by Anton Vinogradov <av...@gridgain.com>.
Done,
https://cwiki.apache.org/confluence/display/IGNITE/Issues+waiting+for+review
On Thu, Mar 17, 2016 at 3:46 PM, Denis Magda <dm...@gridgain.com> wrote:
> Pavel, Anton,
>
> Can we simply create a page on Apache wiki that will show a result of the
> specific JIRA filter execution? This can be the first improvement we can do
> in this direction.
>
> --
> Denis
>
>
> On 3/4/2016 4:14 PM, Anton Vinogradov wrote:
>
>> Pavel,
>> I think that script should be stored inside TeamCity task.
>>
>>
>>
>> On Fri, Mar 4, 2016 at 3:56 PM, Pavel Tupitsyn <pt...@gridgain.com>
>> wrote:
>>
>> Anton, good idea, the script can be stored in git this way. Dmitriy, what
>>> do you think?
>>>
>>> Another question is the email account to send from. Do we have something
>>> suitable already?
>>>
>>>
>>>
>>> On Fri, Mar 4, 2016 at 3:34 PM, Anton Vinogradov <
>>> avinogradov@gridgain.com
>>> wrote:
>>>
>>> Folks,
>>>>
>>>> we can create TeamCity task with special trigger (eg. once a day).
>>>> This task can contains any script.
>>>>
>>>> On Fri, Mar 4, 2016 at 3:18 PM, Pavel Tupitsyn <pt...@gridgain.com>
>>>> wrote:
>>>>
>>>> Raul, I'm not good with shell scripts. As a .net person I was thinking
>>>>> about a scheduled C# script on one of our TeamCity win machines, but
>>>>>
>>>> Dmitry
>>>>
>>>>> prefers Jenkins.
>>>>>
>>>>>
>>>>> On Fri, Mar 4, 2016 at 2:52 PM, Raul Kripalani <ra...@apache.org>
>>>>>
>>>> wrote:
>>>
>>>> I believe all we need is a shell script in our source tree that
>>>>>>
>>>>> queries
>>>
>>>> the
>>>>>
>>>>>> JIRA API and produces an output on stdout.
>>>>>>
>>>>>> We can then schedule an overnight job with, e.g. a 0 23 * * * cron
>>>>>> expression, and configure the output to be sent to the ML, as
>>>>>>
>>>>> indicated
>>>
>>>> here: https://wiki.apache.org/general/Jenkins.
>>>>>>
>>>>>> @Pavel, would you like to work on the shell script? I can help you
>>>>>> configure the JKS job.
>>>>>>
>>>>>> @Dmitriy, can you add both Pavel and me as job admins?
>>>>>>
>>>>>>
>>>>>>
>>> https://wiki.apache.org/general/Jenkins?action=show&redirect=Hudson#How_do_I_get_an_account
>>>
>>>> Cheers,
>>>>>>
>>>>>>
>
Re: Contributions that are waiting for review
Posted by Denis Magda <dm...@gridgain.com>.
Pavel, Anton,
Can we simply create a page on Apache wiki that will show a result of
the specific JIRA filter execution? This can be the first improvement we
can do in this direction.
--
Denis
On 3/4/2016 4:14 PM, Anton Vinogradov wrote:
> Pavel,
> I think that script should be stored inside TeamCity task.
>
>
>
> On Fri, Mar 4, 2016 at 3:56 PM, Pavel Tupitsyn <pt...@gridgain.com>
> wrote:
>
>> Anton, good idea, the script can be stored in git this way. Dmitriy, what
>> do you think?
>>
>> Another question is the email account to send from. Do we have something
>> suitable already?
>>
>>
>>
>> On Fri, Mar 4, 2016 at 3:34 PM, Anton Vinogradov <avinogradov@gridgain.com
>> wrote:
>>
>>> Folks,
>>>
>>> we can create TeamCity task with special trigger (eg. once a day).
>>> This task can contains any script.
>>>
>>> On Fri, Mar 4, 2016 at 3:18 PM, Pavel Tupitsyn <pt...@gridgain.com>
>>> wrote:
>>>
>>>> Raul, I'm not good with shell scripts. As a .net person I was thinking
>>>> about a scheduled C# script on one of our TeamCity win machines, but
>>> Dmitry
>>>> prefers Jenkins.
>>>>
>>>>
>>>> On Fri, Mar 4, 2016 at 2:52 PM, Raul Kripalani <ra...@apache.org>
>> wrote:
>>>>> I believe all we need is a shell script in our source tree that
>> queries
>>>> the
>>>>> JIRA API and produces an output on stdout.
>>>>>
>>>>> We can then schedule an overnight job with, e.g. a 0 23 * * * cron
>>>>> expression, and configure the output to be sent to the ML, as
>> indicated
>>>>> here: https://wiki.apache.org/general/Jenkins.
>>>>>
>>>>> @Pavel, would you like to work on the shell script? I can help you
>>>>> configure the JKS job.
>>>>>
>>>>> @Dmitriy, can you add both Pavel and me as job admins?
>>>>>
>>>>>
>> https://wiki.apache.org/general/Jenkins?action=show&redirect=Hudson#How_do_I_get_an_account
>>>>> Cheers,
>>>>>
Re: Contributions that are waiting for review
Posted by Anton Vinogradov <av...@gridgain.com>.
Pavel,
I think that script should be stored inside TeamCity task.
On Fri, Mar 4, 2016 at 3:56 PM, Pavel Tupitsyn <pt...@gridgain.com>
wrote:
> Anton, good idea, the script can be stored in git this way. Dmitriy, what
> do you think?
>
> Another question is the email account to send from. Do we have something
> suitable already?
>
>
>
> On Fri, Mar 4, 2016 at 3:34 PM, Anton Vinogradov <avinogradov@gridgain.com
> >
> wrote:
>
> > Folks,
> >
> > we can create TeamCity task with special trigger (eg. once a day).
> > This task can contains any script.
> >
> > On Fri, Mar 4, 2016 at 3:18 PM, Pavel Tupitsyn <pt...@gridgain.com>
> > wrote:
> >
> > > Raul, I'm not good with shell scripts. As a .net person I was thinking
> > > about a scheduled C# script on one of our TeamCity win machines, but
> > Dmitry
> > > prefers Jenkins.
> > >
> > >
> > > On Fri, Mar 4, 2016 at 2:52 PM, Raul Kripalani <ra...@apache.org>
> wrote:
> > >
> > > > I believe all we need is a shell script in our source tree that
> queries
> > > the
> > > > JIRA API and produces an output on stdout.
> > > >
> > > > We can then schedule an overnight job with, e.g. a 0 23 * * * cron
> > > > expression, and configure the output to be sent to the ML, as
> indicated
> > > > here: https://wiki.apache.org/general/Jenkins.
> > > >
> > > > @Pavel, would you like to work on the shell script? I can help you
> > > > configure the JKS job.
> > > >
> > > > @Dmitriy, can you add both Pavel and me as job admins?
> > > >
> > > >
> > >
> >
> https://wiki.apache.org/general/Jenkins?action=show&redirect=Hudson#How_do_I_get_an_account
> > > >
> > > > Cheers,
> > > >
> > >
> >
>
Re: Contributions that are waiting for review
Posted by Pavel Tupitsyn <pt...@gridgain.com>.
Anton, good idea, the script can be stored in git this way. Dmitriy, what
do you think?
Another question is the email account to send from. Do we have something
suitable already?
On Fri, Mar 4, 2016 at 3:34 PM, Anton Vinogradov <av...@gridgain.com>
wrote:
> Folks,
>
> we can create TeamCity task with special trigger (eg. once a day).
> This task can contains any script.
>
> On Fri, Mar 4, 2016 at 3:18 PM, Pavel Tupitsyn <pt...@gridgain.com>
> wrote:
>
> > Raul, I'm not good with shell scripts. As a .net person I was thinking
> > about a scheduled C# script on one of our TeamCity win machines, but
> Dmitry
> > prefers Jenkins.
> >
> >
> > On Fri, Mar 4, 2016 at 2:52 PM, Raul Kripalani <ra...@apache.org> wrote:
> >
> > > I believe all we need is a shell script in our source tree that queries
> > the
> > > JIRA API and produces an output on stdout.
> > >
> > > We can then schedule an overnight job with, e.g. a 0 23 * * * cron
> > > expression, and configure the output to be sent to the ML, as indicated
> > > here: https://wiki.apache.org/general/Jenkins.
> > >
> > > @Pavel, would you like to work on the shell script? I can help you
> > > configure the JKS job.
> > >
> > > @Dmitriy, can you add both Pavel and me as job admins?
> > >
> > >
> >
> https://wiki.apache.org/general/Jenkins?action=show&redirect=Hudson#How_do_I_get_an_account
> > >
> > > Cheers,
> > >
> >
>
Re: Contributions that are waiting for review
Posted by Anton Vinogradov <av...@gridgain.com>.
Folks,
we can create TeamCity task with special trigger (eg. once a day).
This task can contains any script.
On Fri, Mar 4, 2016 at 3:18 PM, Pavel Tupitsyn <pt...@gridgain.com>
wrote:
> Raul, I'm not good with shell scripts. As a .net person I was thinking
> about a scheduled C# script on one of our TeamCity win machines, but Dmitry
> prefers Jenkins.
>
>
> On Fri, Mar 4, 2016 at 2:52 PM, Raul Kripalani <ra...@apache.org> wrote:
>
> > I believe all we need is a shell script in our source tree that queries
> the
> > JIRA API and produces an output on stdout.
> >
> > We can then schedule an overnight job with, e.g. a 0 23 * * * cron
> > expression, and configure the output to be sent to the ML, as indicated
> > here: https://wiki.apache.org/general/Jenkins.
> >
> > @Pavel, would you like to work on the shell script? I can help you
> > configure the JKS job.
> >
> > @Dmitriy, can you add both Pavel and me as job admins?
> >
> >
> https://wiki.apache.org/general/Jenkins?action=show&redirect=Hudson#How_do_I_get_an_account
> >
> > Cheers,
> >
>
Re: Contributions that are waiting for review
Posted by Pavel Tupitsyn <pt...@gridgain.com>.
Raul, I'm not good with shell scripts. As a .net person I was thinking
about a scheduled C# script on one of our TeamCity win machines, but Dmitry
prefers Jenkins.
On Fri, Mar 4, 2016 at 2:52 PM, Raul Kripalani <ra...@apache.org> wrote:
> I believe all we need is a shell script in our source tree that queries the
> JIRA API and produces an output on stdout.
>
> We can then schedule an overnight job with, e.g. a 0 23 * * * cron
> expression, and configure the output to be sent to the ML, as indicated
> here: https://wiki.apache.org/general/Jenkins.
>
> @Pavel, would you like to work on the shell script? I can help you
> configure the JKS job.
>
> @Dmitriy, can you add both Pavel and me as job admins?
>
> https://wiki.apache.org/general/Jenkins?action=show&redirect=Hudson#How_do_I_get_an_account
>
> Cheers,
>
Re: Contributions that are waiting for review
Posted by Raul Kripalani <ra...@apache.org>.
I believe all we need is a shell script in our source tree that queries the
JIRA API and produces an output on stdout.
We can then schedule an overnight job with, e.g. a 0 23 * * * cron
expression, and configure the output to be sent to the ML, as indicated
here: https://wiki.apache.org/general/Jenkins.
@Pavel, would you like to work on the shell script? I can help you
configure the JKS job.
@Dmitriy, can you add both Pavel and me as job admins?
https://wiki.apache.org/general/Jenkins?action=show&redirect=Hudson#How_do_I_get_an_account
Cheers,
Re: Contributions that are waiting for review
Posted by Dmitriy Setrakyan <ds...@apache.org>.
My preference would be Jenkins. Raul, do you know how to set it up?
On Thu, Mar 3, 2016 at 10:08 AM, Raul Kripalani <ra...@apache.org> wrote:
> Cool! Do you think you can host it at GridGain?
>
> Else, we could run it as a Jenkins job in the ASF Jenkins.
>
> Regards,
>
> *Raúl Kripalani*
> PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data and
> Messaging Engineer
> http://about.me/raulkripalani | http://www.linkedin.com/in/raulkripalani
> Blog: raul.io | twitter: @raulvk <https://twitter.com/raulvk>
>
> On Thu, Mar 3, 2016 at 3:38 PM, Pavel Tupitsyn <pt...@gridgain.com>
> wrote:
>
> > +1 for Raul, great idea.
> > We can also include a column with "days since last update" to see how
> long
> > each issue has been waiting.
> >
> > I have some experience with JIRA REST API, so maybe I could help with
> this.
> >
> > On Thu, Mar 3, 2016 at 6:24 PM, Raul Kripalani <ra...@apache.org> wrote:
> >
> > > How about a nightly job that fetches all tickets from JIRA which are
> > > unresolved and have Patch Available = true, and (1) sends them to the
> dev
> > > ML or (2) posts it in Gitter?
> > >
> > > Will it help raise awareness and put them on the radar?
> > >
> > > Raúl.
> > > On 2 Mar 2016 20:47, "Denis Magda" <dm...@gridgain.com> wrote:
> > >
> > > >
> > > > I would better ask contributors to ping committers on the dev list
> > when a
> > > > patch is available asking for review.
> > > > It can happen that committers missed or forgot to do the review and a
> > > > contributor can remind them sending one more email to the dev list.
> > > >
> > > > I don't see anything wrong with this approach. It's an open source
> > > project
> > > > and most of the people don't keep an eye on new contributions that
> have
> > > to
> > > > be released.
> > > >
> > > > PATCH_AVAILABLE stat is a right point. But I won't execute this
> filter
> > > all
> > > > the time checking for pending reviews and some of the committers
> don't
> > > move
> > > > the ticket to the CLOSED state when everything is merged.
> > > > The latter was discussed some time ago there.
> > > >
> > > > --
> > > > Denis
> > > >
> > > > On 3/2/2016 6:02 PM, Anton Vinogradov wrote:
> > > >
> > > >> Denis,
> > > >>
> > > >> We have a special status at Ignite JIRA - PATCH AVAILABLE which
> means
> > > that
> > > >> issue ready to be reviewed.
> > > >> Currently 59 issues has such status according to
> > > >>
> > > >>
> > >
> >
> https://issues.apache.org/jira/issues/?filter=-2&jql=project%20%3D%20Ignite%20and%20status%20%3D%20%22Patch%20Available%22
> > > >>
> > > >> I think we have to add notes that this status can be used only
> during
> > > >> waiting of review and we will have no problems with actual "required
> > > >> review" list in future.
> > > >>
> > > >>
> > > >> On Wed, Mar 2, 2016 at 4:08 PM, Roman Shtykh
> > <rshtykh@yahoo.com.invalid
> > > >
> > > >> wrote:
> > > >>
> > > >> I have also asked for review of the following tickets but failed to
> > get
> > > a
> > > >>> feedback.
> > > >>> They are not complicated, but I would appreciate a quick review.
> > Thank
> > > >>> you!
> > > >>>
> > > >>> [IGNITE-2563] Queries: ArrayIndexOutOfBoundsException when using
> > > BOOL_AND
> > > >>>
> > > >>> https://issues.apache.org/jira/browse/IGNITE-2563
> > > >>>
> > > >>> IGNITE-2416 TcpDiscoverySharedFsIpFinder doesn't work with IPv6
> > > addresses
> > > >>> https://issues.apache.org/jira/browse/IGNITE-2416
> > > >>>
> > > >>> and a new one
> > > >>>
> > > >>> IGNITE-2710 Session not unbind from current request after invoking
> > > >>> request.getSession().invalidate()
> > > >>> https://issues.apache.org/jira/browse/IGNITE-2710
> > > >>>
> > > >>> -Roman
> > > >>>
> > > >>>
> > > >>> On Wednesday, March 2, 2016 6:38 PM, Denis Magda <
> > dmagda@gridgain.com>
> > > >>> wrote:
> > > >>>
> > > >>>
> > > >>>
> > > >>> Ignite committers,
> > > >>>
> > > >>> There is a number of contributions that have to be reviewed.
> > > >>>
> > > >>> Please pick them up basing on your experience and provide your
> review
> > > >>> notes.
> > > >>>
> > > >>> Ignite 2718: Missing ZookeeperIpFinder dependencies
> > > >>> <https://issues.apache.org/jira/browse/IGNITE-2718>
> > > >>> IGNITE-2693: withKeepBinary and non-binary marshallers
> > > >>> <https://issues.apache.org/jira/browse/IGNITE-2693>
> > > >>> IGNITE-2735: Fixes distributed semaphore local node stopping issue.
> > > >>> <https://issues.apache.org/jira/browse/IGNITE-2735>
> > > >>> *IGNITE-642: Implements cache distributed reentrant lock
> > > >>> <https://issues.apache.org/jira/browse/IGNITE-642>
> > > >>>
> > > >>>
> > > >>> *Regards,
> > > >>> Denis
> > > >>>
> > > >>>
> > > >
> > >
> >
>
Re: Contributions that are waiting for review
Posted by Raul Kripalani <ra...@apache.org>.
Cool! Do you think you can host it at GridGain?
Else, we could run it as a Jenkins job in the ASF Jenkins.
Regards,
*Raúl Kripalani*
PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data and
Messaging Engineer
http://about.me/raulkripalani | http://www.linkedin.com/in/raulkripalani
Blog: raul.io | twitter: @raulvk <https://twitter.com/raulvk>
On Thu, Mar 3, 2016 at 3:38 PM, Pavel Tupitsyn <pt...@gridgain.com>
wrote:
> +1 for Raul, great idea.
> We can also include a column with "days since last update" to see how long
> each issue has been waiting.
>
> I have some experience with JIRA REST API, so maybe I could help with this.
>
> On Thu, Mar 3, 2016 at 6:24 PM, Raul Kripalani <ra...@apache.org> wrote:
>
> > How about a nightly job that fetches all tickets from JIRA which are
> > unresolved and have Patch Available = true, and (1) sends them to the dev
> > ML or (2) posts it in Gitter?
> >
> > Will it help raise awareness and put them on the radar?
> >
> > Raúl.
> > On 2 Mar 2016 20:47, "Denis Magda" <dm...@gridgain.com> wrote:
> >
> > >
> > > I would better ask contributors to ping committers on the dev list
> when a
> > > patch is available asking for review.
> > > It can happen that committers missed or forgot to do the review and a
> > > contributor can remind them sending one more email to the dev list.
> > >
> > > I don't see anything wrong with this approach. It's an open source
> > project
> > > and most of the people don't keep an eye on new contributions that have
> > to
> > > be released.
> > >
> > > PATCH_AVAILABLE stat is a right point. But I won't execute this filter
> > all
> > > the time checking for pending reviews and some of the committers don't
> > move
> > > the ticket to the CLOSED state when everything is merged.
> > > The latter was discussed some time ago there.
> > >
> > > --
> > > Denis
> > >
> > > On 3/2/2016 6:02 PM, Anton Vinogradov wrote:
> > >
> > >> Denis,
> > >>
> > >> We have a special status at Ignite JIRA - PATCH AVAILABLE which means
> > that
> > >> issue ready to be reviewed.
> > >> Currently 59 issues has such status according to
> > >>
> > >>
> >
> https://issues.apache.org/jira/issues/?filter=-2&jql=project%20%3D%20Ignite%20and%20status%20%3D%20%22Patch%20Available%22
> > >>
> > >> I think we have to add notes that this status can be used only during
> > >> waiting of review and we will have no problems with actual "required
> > >> review" list in future.
> > >>
> > >>
> > >> On Wed, Mar 2, 2016 at 4:08 PM, Roman Shtykh
> <rshtykh@yahoo.com.invalid
> > >
> > >> wrote:
> > >>
> > >> I have also asked for review of the following tickets but failed to
> get
> > a
> > >>> feedback.
> > >>> They are not complicated, but I would appreciate a quick review.
> Thank
> > >>> you!
> > >>>
> > >>> [IGNITE-2563] Queries: ArrayIndexOutOfBoundsException when using
> > BOOL_AND
> > >>>
> > >>> https://issues.apache.org/jira/browse/IGNITE-2563
> > >>>
> > >>> IGNITE-2416 TcpDiscoverySharedFsIpFinder doesn't work with IPv6
> > addresses
> > >>> https://issues.apache.org/jira/browse/IGNITE-2416
> > >>>
> > >>> and a new one
> > >>>
> > >>> IGNITE-2710 Session not unbind from current request after invoking
> > >>> request.getSession().invalidate()
> > >>> https://issues.apache.org/jira/browse/IGNITE-2710
> > >>>
> > >>> -Roman
> > >>>
> > >>>
> > >>> On Wednesday, March 2, 2016 6:38 PM, Denis Magda <
> dmagda@gridgain.com>
> > >>> wrote:
> > >>>
> > >>>
> > >>>
> > >>> Ignite committers,
> > >>>
> > >>> There is a number of contributions that have to be reviewed.
> > >>>
> > >>> Please pick them up basing on your experience and provide your review
> > >>> notes.
> > >>>
> > >>> Ignite 2718: Missing ZookeeperIpFinder dependencies
> > >>> <https://issues.apache.org/jira/browse/IGNITE-2718>
> > >>> IGNITE-2693: withKeepBinary and non-binary marshallers
> > >>> <https://issues.apache.org/jira/browse/IGNITE-2693>
> > >>> IGNITE-2735: Fixes distributed semaphore local node stopping issue.
> > >>> <https://issues.apache.org/jira/browse/IGNITE-2735>
> > >>> *IGNITE-642: Implements cache distributed reentrant lock
> > >>> <https://issues.apache.org/jira/browse/IGNITE-642>
> > >>>
> > >>>
> > >>> *Regards,
> > >>> Denis
> > >>>
> > >>>
> > >
> >
>
Re: Contributions that are waiting for review
Posted by Pavel Tupitsyn <pt...@gridgain.com>.
+1 for Raul, great idea.
We can also include a column with "days since last update" to see how long
each issue has been waiting.
I have some experience with JIRA REST API, so maybe I could help with this.
On Thu, Mar 3, 2016 at 6:24 PM, Raul Kripalani <ra...@apache.org> wrote:
> How about a nightly job that fetches all tickets from JIRA which are
> unresolved and have Patch Available = true, and (1) sends them to the dev
> ML or (2) posts it in Gitter?
>
> Will it help raise awareness and put them on the radar?
>
> Raúl.
> On 2 Mar 2016 20:47, "Denis Magda" <dm...@gridgain.com> wrote:
>
> >
> > I would better ask contributors to ping committers on the dev list when a
> > patch is available asking for review.
> > It can happen that committers missed or forgot to do the review and a
> > contributor can remind them sending one more email to the dev list.
> >
> > I don't see anything wrong with this approach. It's an open source
> project
> > and most of the people don't keep an eye on new contributions that have
> to
> > be released.
> >
> > PATCH_AVAILABLE stat is a right point. But I won't execute this filter
> all
> > the time checking for pending reviews and some of the committers don't
> move
> > the ticket to the CLOSED state when everything is merged.
> > The latter was discussed some time ago there.
> >
> > --
> > Denis
> >
> > On 3/2/2016 6:02 PM, Anton Vinogradov wrote:
> >
> >> Denis,
> >>
> >> We have a special status at Ignite JIRA - PATCH AVAILABLE which means
> that
> >> issue ready to be reviewed.
> >> Currently 59 issues has such status according to
> >>
> >>
> https://issues.apache.org/jira/issues/?filter=-2&jql=project%20%3D%20Ignite%20and%20status%20%3D%20%22Patch%20Available%22
> >>
> >> I think we have to add notes that this status can be used only during
> >> waiting of review and we will have no problems with actual "required
> >> review" list in future.
> >>
> >>
> >> On Wed, Mar 2, 2016 at 4:08 PM, Roman Shtykh <rshtykh@yahoo.com.invalid
> >
> >> wrote:
> >>
> >> I have also asked for review of the following tickets but failed to get
> a
> >>> feedback.
> >>> They are not complicated, but I would appreciate a quick review. Thank
> >>> you!
> >>>
> >>> [IGNITE-2563] Queries: ArrayIndexOutOfBoundsException when using
> BOOL_AND
> >>>
> >>> https://issues.apache.org/jira/browse/IGNITE-2563
> >>>
> >>> IGNITE-2416 TcpDiscoverySharedFsIpFinder doesn't work with IPv6
> addresses
> >>> https://issues.apache.org/jira/browse/IGNITE-2416
> >>>
> >>> and a new one
> >>>
> >>> IGNITE-2710 Session not unbind from current request after invoking
> >>> request.getSession().invalidate()
> >>> https://issues.apache.org/jira/browse/IGNITE-2710
> >>>
> >>> -Roman
> >>>
> >>>
> >>> On Wednesday, March 2, 2016 6:38 PM, Denis Magda <dm...@gridgain.com>
> >>> wrote:
> >>>
> >>>
> >>>
> >>> Ignite committers,
> >>>
> >>> There is a number of contributions that have to be reviewed.
> >>>
> >>> Please pick them up basing on your experience and provide your review
> >>> notes.
> >>>
> >>> Ignite 2718: Missing ZookeeperIpFinder dependencies
> >>> <https://issues.apache.org/jira/browse/IGNITE-2718>
> >>> IGNITE-2693: withKeepBinary and non-binary marshallers
> >>> <https://issues.apache.org/jira/browse/IGNITE-2693>
> >>> IGNITE-2735: Fixes distributed semaphore local node stopping issue.
> >>> <https://issues.apache.org/jira/browse/IGNITE-2735>
> >>> *IGNITE-642: Implements cache distributed reentrant lock
> >>> <https://issues.apache.org/jira/browse/IGNITE-642>
> >>>
> >>>
> >>> *Regards,
> >>> Denis
> >>>
> >>>
> >
>
Re: Contributions that are waiting for review
Posted by Raul Kripalani <ra...@apache.org>.
How about a nightly job that fetches all tickets from JIRA which are
unresolved and have Patch Available = true, and (1) sends them to the dev
ML or (2) posts it in Gitter?
Will it help raise awareness and put them on the radar?
Raúl.
On 2 Mar 2016 20:47, "Denis Magda" <dm...@gridgain.com> wrote:
>
> I would better ask contributors to ping committers on the dev list when a
> patch is available asking for review.
> It can happen that committers missed or forgot to do the review and a
> contributor can remind them sending one more email to the dev list.
>
> I don't see anything wrong with this approach. It's an open source project
> and most of the people don't keep an eye on new contributions that have to
> be released.
>
> PATCH_AVAILABLE stat is a right point. But I won't execute this filter all
> the time checking for pending reviews and some of the committers don't move
> the ticket to the CLOSED state when everything is merged.
> The latter was discussed some time ago there.
>
> --
> Denis
>
> On 3/2/2016 6:02 PM, Anton Vinogradov wrote:
>
>> Denis,
>>
>> We have a special status at Ignite JIRA - PATCH AVAILABLE which means that
>> issue ready to be reviewed.
>> Currently 59 issues has such status according to
>>
>> https://issues.apache.org/jira/issues/?filter=-2&jql=project%20%3D%20Ignite%20and%20status%20%3D%20%22Patch%20Available%22
>>
>> I think we have to add notes that this status can be used only during
>> waiting of review and we will have no problems with actual "required
>> review" list in future.
>>
>>
>> On Wed, Mar 2, 2016 at 4:08 PM, Roman Shtykh <rs...@yahoo.com.invalid>
>> wrote:
>>
>> I have also asked for review of the following tickets but failed to get a
>>> feedback.
>>> They are not complicated, but I would appreciate a quick review. Thank
>>> you!
>>>
>>> [IGNITE-2563] Queries: ArrayIndexOutOfBoundsException when using BOOL_AND
>>>
>>> https://issues.apache.org/jira/browse/IGNITE-2563
>>>
>>> IGNITE-2416 TcpDiscoverySharedFsIpFinder doesn't work with IPv6 addresses
>>> https://issues.apache.org/jira/browse/IGNITE-2416
>>>
>>> and a new one
>>>
>>> IGNITE-2710 Session not unbind from current request after invoking
>>> request.getSession().invalidate()
>>> https://issues.apache.org/jira/browse/IGNITE-2710
>>>
>>> -Roman
>>>
>>>
>>> On Wednesday, March 2, 2016 6:38 PM, Denis Magda <dm...@gridgain.com>
>>> wrote:
>>>
>>>
>>>
>>> Ignite committers,
>>>
>>> There is a number of contributions that have to be reviewed.
>>>
>>> Please pick them up basing on your experience and provide your review
>>> notes.
>>>
>>> Ignite 2718: Missing ZookeeperIpFinder dependencies
>>> <https://issues.apache.org/jira/browse/IGNITE-2718>
>>> IGNITE-2693: withKeepBinary and non-binary marshallers
>>> <https://issues.apache.org/jira/browse/IGNITE-2693>
>>> IGNITE-2735: Fixes distributed semaphore local node stopping issue.
>>> <https://issues.apache.org/jira/browse/IGNITE-2735>
>>> *IGNITE-642: Implements cache distributed reentrant lock
>>> <https://issues.apache.org/jira/browse/IGNITE-642>
>>>
>>>
>>> *Regards,
>>> Denis
>>>
>>>
>
Re: Contributions that are waiting for review
Posted by Denis Magda <dm...@gridgain.com>.
I would better ask contributors to ping committers on the dev list when
a patch is available asking for review.
It can happen that committers missed or forgot to do the review and a
contributor can remind them sending one more email to the dev list.
I don't see anything wrong with this approach. It's an open source
project and most of the people don't keep an eye on new contributions
that have to be released.
PATCH_AVAILABLE stat is a right point. But I won't execute this filter
all the time checking for pending reviews and some of the committers
don't move the ticket to the CLOSED state when everything is merged.
The latter was discussed some time ago there.
--
Denis
On 3/2/2016 6:02 PM, Anton Vinogradov wrote:
> Denis,
>
> We have a special status at Ignite JIRA - PATCH AVAILABLE which means that
> issue ready to be reviewed.
> Currently 59 issues has such status according to
> https://issues.apache.org/jira/issues/?filter=-2&jql=project%20%3D%20Ignite%20and%20status%20%3D%20%22Patch%20Available%22
>
> I think we have to add notes that this status can be used only during
> waiting of review and we will have no problems with actual "required
> review" list in future.
>
>
> On Wed, Mar 2, 2016 at 4:08 PM, Roman Shtykh <rs...@yahoo.com.invalid>
> wrote:
>
>> I have also asked for review of the following tickets but failed to get a
>> feedback.
>> They are not complicated, but I would appreciate a quick review. Thank you!
>>
>> [IGNITE-2563] Queries: ArrayIndexOutOfBoundsException when using BOOL_AND
>>
>> https://issues.apache.org/jira/browse/IGNITE-2563
>>
>> IGNITE-2416 TcpDiscoverySharedFsIpFinder doesn't work with IPv6 addresses
>> https://issues.apache.org/jira/browse/IGNITE-2416
>>
>> and a new one
>>
>> IGNITE-2710 Session not unbind from current request after invoking
>> request.getSession().invalidate()
>> https://issues.apache.org/jira/browse/IGNITE-2710
>>
>> -Roman
>>
>>
>> On Wednesday, March 2, 2016 6:38 PM, Denis Magda <dm...@gridgain.com>
>> wrote:
>>
>>
>>
>> Ignite committers,
>>
>> There is a number of contributions that have to be reviewed.
>>
>> Please pick them up basing on your experience and provide your review
>> notes.
>>
>> Ignite 2718: Missing ZookeeperIpFinder dependencies
>> <https://issues.apache.org/jira/browse/IGNITE-2718>
>> IGNITE-2693: withKeepBinary and non-binary marshallers
>> <https://issues.apache.org/jira/browse/IGNITE-2693>
>> IGNITE-2735: Fixes distributed semaphore local node stopping issue.
>> <https://issues.apache.org/jira/browse/IGNITE-2735>
>> *IGNITE-642: Implements cache distributed reentrant lock
>> <https://issues.apache.org/jira/browse/IGNITE-642>
>>
>>
>> *Regards,
>> Denis
>>
Re: Contributions that are waiting for review
Posted by Anton Vinogradov <av...@gridgain.com>.
Denis,
We have a special status at Ignite JIRA - PATCH AVAILABLE which means that
issue ready to be reviewed.
Currently 59 issues has such status according to
https://issues.apache.org/jira/issues/?filter=-2&jql=project%20%3D%20Ignite%20and%20status%20%3D%20%22Patch%20Available%22
I think we have to add notes that this status can be used only during
waiting of review and we will have no problems with actual "required
review" list in future.
On Wed, Mar 2, 2016 at 4:08 PM, Roman Shtykh <rs...@yahoo.com.invalid>
wrote:
> I have also asked for review of the following tickets but failed to get a
> feedback.
> They are not complicated, but I would appreciate a quick review. Thank you!
>
> [IGNITE-2563] Queries: ArrayIndexOutOfBoundsException when using BOOL_AND
>
> https://issues.apache.org/jira/browse/IGNITE-2563
>
> IGNITE-2416 TcpDiscoverySharedFsIpFinder doesn't work with IPv6 addresses
> https://issues.apache.org/jira/browse/IGNITE-2416
>
> and a new one
>
> IGNITE-2710 Session not unbind from current request after invoking
> request.getSession().invalidate()
> https://issues.apache.org/jira/browse/IGNITE-2710
>
> -Roman
>
>
> On Wednesday, March 2, 2016 6:38 PM, Denis Magda <dm...@gridgain.com>
> wrote:
>
>
>
> Ignite committers,
>
> There is a number of contributions that have to be reviewed.
>
> Please pick them up basing on your experience and provide your review
> notes.
>
> Ignite 2718: Missing ZookeeperIpFinder dependencies
> <https://issues.apache.org/jira/browse/IGNITE-2718>
> IGNITE-2693: withKeepBinary and non-binary marshallers
> <https://issues.apache.org/jira/browse/IGNITE-2693>
> IGNITE-2735: Fixes distributed semaphore local node stopping issue.
> <https://issues.apache.org/jira/browse/IGNITE-2735>
> *IGNITE-642: Implements cache distributed reentrant lock
> <https://issues.apache.org/jira/browse/IGNITE-642>
>
>
> *Regards,
> Denis
>
Re: Contributions that are waiting for review
Posted by Roman Shtykh <rs...@yahoo.com.INVALID>.
I have also asked for review of the following tickets but failed to get a feedback.
They are not complicated, but I would appreciate a quick review. Thank you!
[IGNITE-2563] Queries: ArrayIndexOutOfBoundsException when using BOOL_AND
https://issues.apache.org/jira/browse/IGNITE-2563
IGNITE-2416 TcpDiscoverySharedFsIpFinder doesn't work with IPv6 addresses
https://issues.apache.org/jira/browse/IGNITE-2416
and a new one
IGNITE-2710 Session not unbind from current request after invoking request.getSession().invalidate()
https://issues.apache.org/jira/browse/IGNITE-2710
-Roman
On Wednesday, March 2, 2016 6:38 PM, Denis Magda <dm...@gridgain.com> wrote:
Ignite committers,
There is a number of contributions that have to be reviewed.
Please pick them up basing on your experience and provide your review notes.
Ignite 2718: Missing ZookeeperIpFinder dependencies
<https://issues.apache.org/jira/browse/IGNITE-2718>
IGNITE-2693: withKeepBinary and non-binary marshallers
<https://issues.apache.org/jira/browse/IGNITE-2693>
IGNITE-2735: Fixes distributed semaphore local node stopping issue.
<https://issues.apache.org/jira/browse/IGNITE-2735>
*IGNITE-642: Implements cache distributed reentrant lock
<https://issues.apache.org/jira/browse/IGNITE-642>
*Regards,
Denis