You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/12/28 07:12:02 UTC
[GitHub] [incubator-devlake] warren830 opened a new pull request, #4051: fix(github): update incremental support for check run
warren830 opened a new pull request, #4051:
URL: https://github.com/apache/incubator-devlake/pull/4051
### Summary
1. fix refdiff in bp v200
2. add incremental support for github graphql check run
### Does this close any open issues?
relate to #3688
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh merged pull request #4051: fix(github): update incremental support for check run
Posted by GitBox <gi...@apache.org>.
likyh merged PR #4051:
URL: https://github.com/apache/incubator-devlake/pull/4051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on a diff in pull request #4051: fix(github): update incremental support for check run
Posted by GitBox <gi...@apache.org>.
likyh commented on code in PR #4051:
URL: https://github.com/apache/incubator-devlake/pull/4051#discussion_r1058324843
##########
plugins/helper/graphql_collector.go:
##########
@@ -66,6 +66,8 @@ type GraphqlCollectorArgs struct {
// how many times fetched from input, default 1 means only fetch once
// NOTICE: InputStep=1 will fill value as item and InputStep>1 will fill value as []item
InputStep int
+ // Incremental indicate if this is a incremental collection, the existing data won't get deleted if it was true
+ Incremental bool `comment:""`
Review Comment:
why add tag `comment` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #4051: fix(github): update incremental support for check run
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #4051:
URL: https://github.com/apache/incubator-devlake/pull/4051#discussion_r1058687370
##########
plugins/helper/graphql_collector.go:
##########
@@ -66,6 +66,8 @@ type GraphqlCollectorArgs struct {
// how many times fetched from input, default 1 means only fetch once
// NOTICE: InputStep=1 will fill value as item and InputStep>1 will fill value as []item
InputStep int
+ // Incremental indicate if this is a incremental collection, the existing data won't get deleted if it was true
+ Incremental bool `comment:""`
Review Comment:
This comes from api_collector, I will delete it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org