You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "PG1204 (via GitHub)" <gi...@apache.org> on 2026/08/03 22:57:13 UTC
[PR] fix(workflow-operator): give a clear error when the HF result column collides with an input column [texera]
PG1204 opened a new pull request, #7298:
URL: https://github.com/apache/texera/pull/7298
### What changes were proposed in this PR?
If the HuggingFace operator's Result Column Name matches an existing input column, `getOutputSchemas` reached `Schema.add`, which threw a generic `RuntimeException("Attribute name '...' already exists in the schema")`, which is unhelpful, and it doesn't tell the user what to do.
This adds a pre-check in `getOutputSchemas`: if the resolved result column already exists in the input schema, it throws a clear, actionable message ("Result column '...' already exists in the input table. Choose a different Result Column Name.") instead of the opaque internal error.
### Any related issues, documentation, discussions?
Closes #7198.
### How was this PR tested?
`sbt "WorkflowOperator/testOnly org.apache.texera.amber.operator.huggingFace.*"`: passes (124 tests). Added a test that a colliding result column produces the clear "Result column '...'" error. scalafmt clean.
### Was this PR authored or co-authored using generative AI tooling?
This PR was co-authored with Claude Opus 4.8 in compliance with ASF policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(workflow-operator): give a clear error when the HF result column collides with an input column [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7298:
URL: https://github.com/apache/texera/pull/7298#issuecomment-5172638999
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/7298?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 83.03%. Comparing base ([`7f6402d`](https://app.codecov.io/gh/apache/texera/commit/7f6402d01209ed50fa62ea169c45516bb39f2136?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`db8ec2a`](https://app.codecov.io/gh/apache/texera/commit/db8ec2a892e713c1ebfb6bdda67365c93c098aa4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #7298 +/- ##
============================================
- Coverage 83.03% 83.03% -0.01%
Complexity 4107 4107
============================================
Files 1165 1165
Lines 46405 46404 -1
Branches 5171 5171
============================================
- Hits 38531 38530 -1
Misses 6171 6171
Partials 1703 1703
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/7298/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/7298/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/7298/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.65% <ø> (ø)` | | Carriedforward from [7f6402d](https://app.codecov.io/gh/apache/texera/commit/7f6402d01209ed50fa62ea169c45516bb39f2136?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/7298/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.99% <ø> (-0.01%)` | :arrow_down: | Carriedforward from [7f6402d](https://app.codecov.io/gh/apache/texera/commit/7f6402d01209ed50fa62ea169c45516bb39f2136?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/7298/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.60% <ø> (ø)` | | Carriedforward from [7f6402d](https://app.codecov.io/gh/apache/texera/commit/7f6402d01209ed50fa62ea169c45516bb39f2136?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/7298/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.97% <ø> (ø)` | | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/7298/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.74% <ø> (ø)` | | Carriedforward from [7f6402d](https://app.codecov.io/gh/apache/texera/commit/7f6402d01209ed50fa62ea169c45516bb39f2136?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/7298/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.84% <ø> (ø)` | | Carriedforward from [7f6402d](https://app.codecov.io/gh/apache/texera/commit/7f6402d01209ed50fa62ea169c45516bb39f2136?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/7298/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.89% <ø> (ø)` | | Carriedforward from [7f6402d](https://app.codecov.io/gh/apache/texera/commit/7f6402d01209ed50fa62ea169c45516bb39f2136?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/7298/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `97.32% <ø> (ø)` | | Carriedforward from [7f6402d](https://app.codecov.io/gh/apache/texera/commit/7f6402d01209ed50fa62ea169c45516bb39f2136?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/7298/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.31% <ø> (ø)` | | Carriedforward from [7f6402d](https://app.codecov.io/gh/apache/texera/commit/7f6402d01209ed50fa62ea169c45516bb39f2136?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/7298?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(workflow-operator): give a clear error when the HF result column collides with an input column [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7298:
URL: https://github.com/apache/texera/pull/7298#issuecomment-5172620388
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(workflow-operator): give a clear error when the HF result column collides with an input column [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7298:
URL: https://github.com/apache/texera/pull/7298#issuecomment-5172661738
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 2 better · 🔴 5 worse · ⚪ 8 noise (<±5%) · 0 without baseline
> Compared against main `7f6402d` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/30860555135)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 376 | 0.23 | 25,593/34,880/34,880 us | 🔴 +5.7% / 🔴 +127.4% |
| 🔴 | bs=100 sw=10 sl=64 | 919 | 0.561 | 107,740/129,750/129,750 us | 🟢 -9.4% / 🔴 +23.3% |
| 🔴 | bs=1000 sw=10 sl=64 | 1,096 | 0.669 | 901,388/1,051,080/1,051,080 us | 🔴 +5.8% / 🟢 -6.5% |
<details><summary>Baseline details</summary>
Latest main `7f6402d` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 376 tuples/sec | 397 tuples/sec | 791.9 tuples/sec | -5.3% | -52.5% |
| bs=10 sw=10 sl=64 | MB/s | 0.23 MB/s | 0.242 MB/s | 0.483 MB/s | -5.0% | -52.4% |
| bs=10 sw=10 sl=64 | p50 | 25,593 us | 24,203 us | 12,391 us | +5.7% | +106.5% |
| bs=10 sw=10 sl=64 | p95 | 34,880 us | 35,872 us | 15,336 us | -2.8% | +127.4% |
| bs=10 sw=10 sl=64 | p99 | 34,880 us | 35,872 us | 18,924 us | -2.8% | +84.3% |
| bs=100 sw=10 sl=64 | throughput | 919 tuples/sec | 967 tuples/sec | 1,018 tuples/sec | -5.0% | -9.8% |
| bs=100 sw=10 sl=64 | MB/s | 0.561 MB/s | 0.59 MB/s | 0.622 MB/s | -4.9% | -9.7% |
| bs=100 sw=10 sl=64 | p50 | 107,740 us | 99,009 us | 98,925 us | +8.8% | +8.9% |
| bs=100 sw=10 sl=64 | p95 | 129,750 us | 143,147 us | 105,265 us | -9.4% | +23.3% |
| bs=100 sw=10 sl=64 | p99 | 129,750 us | 143,147 us | 112,729 us | -9.4% | +15.1% |
| bs=1000 sw=10 sl=64 | throughput | 1,096 tuples/sec | 1,083 tuples/sec | 1,051 tuples/sec | +1.2% | +4.3% |
| bs=1000 sw=10 sl=64 | MB/s | 0.669 MB/s | 0.661 MB/s | 0.641 MB/s | +1.2% | +4.3% |
| bs=1000 sw=10 sl=64 | p50 | 901,388 us | 929,207 us | 964,104 us | -3.0% | -6.5% |
| bs=1000 sw=10 sl=64 | p95 | 1,051,080 us | 993,661 us | 1,002,343 us | +5.8% | +4.9% |
| bs=1000 sw=10 sl=64 | p99 | 1,051,080 us | 993,661 us | 1,030,483 us | +5.8% | +2.0% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,531.65,200,128000,376,0.230,25593.25,34879.83,34879.83
1,100,10,64,20,2175.14,2000,1280000,919,0.561,107740.25,129749.81,129749.81
2,1000,10,64,20,18249.02,20000,12800000,1096,0.669,901388.33,1051079.74,1051079.74
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(workflow-operator): give a clear error when the HF result column collides with an input column [texera]
Posted by "PG1204 (via GitHub)" <gi...@apache.org>.
PG1204 commented on PR #7298:
URL: https://github.com/apache/texera/pull/7298#issuecomment-5196992307
/request-review @xuang7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(workflow-operator): give a clear error when the HF result column collides with an input column [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7298:
URL: https://github.com/apache/texera/pull/7298#issuecomment-5172620374
<!-- backport-auto-label-report -->
### Backport auto-label report
This `fix:` PR was checked against each actively-supported release branch. `release/*` labels drive the post-merge backport, so add or remove one to change where this fix lands.
| Release branch | Analysis |
| --- | --- |
| ⚠️ `release/v1.2` | Not labeled automatically — none of the files this PR modifies exist on this branch (`common/workflow-operator/src/main/scala/org/apache/texera/amber/operator/huggingFace/HuggingFaceInferenceOpDesc.scala`, `common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/huggingFace/HuggingFaceInferenceOpDescSpec.scala`). The fix may target code that isn't on this release, or the files were moved/renamed after the branch was cut. **Please check and add `release/v1.2` by hand if this fix should be backported here.** |
_[Auto-label run](https://github.com/apache/texera/actions/runs/30860553257)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(workflow-operator): give a clear error when the HF result column collides with an input column [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #7298:
URL: https://github.com/apache/texera/pull/7298#issuecomment-5212880130
@PG1204 Can you add screenshots?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(workflow-operator): give a clear error when the HF result column collides with an input column [texera]
Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 merged PR #7298:
URL: https://github.com/apache/texera/pull/7298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(workflow-operator): give a clear error when the HF result column collides with an input column [texera]
Posted by "PG1204 (via GitHub)" <gi...@apache.org>.
PG1204 commented on PR #7298:
URL: https://github.com/apache/texera/pull/7298#issuecomment-5214435578
> @PG1204 Can you add screenshots?
@chenlica screenshots are now included in the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org