You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Abhishek Rawat (Code Review)" <ge...@cloudera.org> on 2019/11/05 15:40:09 UTC
[Impala-ASF-CR] IMPALA-8692 INSERT ... () VALUES () Crashes for parquet tables.
Abhishek Rawat has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14634
Change subject: IMPALA-8692 INSERT ... <tbl_w_nestedtype> (<scal_col>) VALUES (<scal_val>) Crashes for parquet tables.
......................................................................
IMPALA-8692 INSERT ... <tbl_w_nestedtype> (<scal_col>) VALUES (<scal_val>) Crashes for parquet tables.
Impala doesn't support writing new data files containing complex type
columns. Block such statements during analysis.
Added new tests in AnalyzeStmtsTest for the blocked scenarios.
Change-Id: I81bd04b2f1cd9873462098f67a45cd3974094d96
---
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
2 files changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/14634/1
--
To view, visit http://gerrit.cloudera.org:8080/14634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81bd04b2f1cd9873462098f67a45cd3974094d96
Gerrit-Change-Number: 14634
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8692 INSERT ... () VALUES () Crashes for parquet tables.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14634 )
Change subject: IMPALA-8692 INSERT ... <tbl_w_nestedtype> (<scal_col>) VALUES (<scal_val>) Crashes for parquet tables.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4945/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81bd04b2f1cd9873462098f67a45cd3974094d96
Gerrit-Change-Number: 14634
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Nov 2019 16:27:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8692 Gracefully fail complex type inserts
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14634 )
Change subject: IMPALA-8692 Gracefully fail complex type inserts
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81bd04b2f1cd9873462098f67a45cd3974094d96
Gerrit-Change-Number: 14634
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Nov 2019 19:31:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8692 INSERT ... () VALUES () Crashes for parquet tables.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14634 )
Change subject: IMPALA-8692 INSERT ... <tbl_w_nestedtype> (<scal_col>) VALUES (<scal_val>) Crashes for parquet tables.
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14634/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14634/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-8692 INSERT ... <tbl_w_nestedtype> (<scal_col>) VALUES (<scal_val>) Crashes for parquet tables.
The commit message should concisely describe the change you made rather than the problem. E.g. "gracefully fail complex type inserts"
http://gerrit.cloudera.org:8080/#/c/14634/1//COMMIT_MSG@9
PS1, Line 9: Impala doesn't support writing new data files containing complex type
I think we reject some insert statements with complex types - how did these ones slip through?
http://gerrit.cloudera.org:8080/#/c/14634/1/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java:
http://gerrit.cloudera.org:8080/#/c/14634/1/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java@457
PS1, Line 457: "support writing new data files containing complex type columns",
I would remove the bit about data files since this also applies to Kudu.
--
To view, visit http://gerrit.cloudera.org:8080/14634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81bd04b2f1cd9873462098f67a45cd3974094d96
Gerrit-Change-Number: 14634
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Nov 2019 17:27:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8692 Gracefully fail complex type inserts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14634 )
Change subject: IMPALA-8692 Gracefully fail complex type inserts
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81bd04b2f1cd9873462098f67a45cd3974094d96
Gerrit-Change-Number: 14634
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Nov 2019 00:01:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8692 Gracefully fail complex type inserts
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14634 )
Change subject: IMPALA-8692 Gracefully fail complex type inserts
......................................................................
IMPALA-8692 Gracefully fail complex type inserts
Impala doesn't support writing new data files containing complex type
columns. Block such statements during analysis.
Added new tests in AnalyzeStmtsTest for the blocked scenarios.
Change-Id: I81bd04b2f1cd9873462098f67a45cd3974094d96
---
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
2 files changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/34/14634/2
--
To view, visit http://gerrit.cloudera.org:8080/14634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I81bd04b2f1cd9873462098f67a45cd3974094d96
Gerrit-Change-Number: 14634
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8692 Gracefully fail complex type inserts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14634 )
Change subject: IMPALA-8692 Gracefully fail complex type inserts
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4950/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81bd04b2f1cd9873462098f67a45cd3974094d96
Gerrit-Change-Number: 14634
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Nov 2019 19:34:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8692 Gracefully fail complex type inserts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14634 )
Change subject: IMPALA-8692 Gracefully fail complex type inserts
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5173/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81bd04b2f1cd9873462098f67a45cd3974094d96
Gerrit-Change-Number: 14634
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Nov 2019 19:31:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8692 INSERT ... () VALUES () Crashes for parquet tables.
Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/14634 )
Change subject: IMPALA-8692 INSERT ... <tbl_w_nestedtype> (<scal_col>) VALUES (<scal_val>) Crashes for parquet tables.
......................................................................
Patch Set 1:
(3 comments)
Thanks, I have addressed the review comments.
http://gerrit.cloudera.org:8080/#/c/14634/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14634/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-8692 INSERT ... <tbl_w_nestedtype> (<scal_col>) VALUES (<scal_val>) Crashes for parquet tables.
> The commit message should concisely describe the change you made rather tha
Thanks, this was unfortunately a bad abstract name derived from the JIRA. I have updated the message to "Gracefully fail complex type inserts"
http://gerrit.cloudera.org:8080/#/c/14634/1//COMMIT_MSG@9
PS1, Line 9: Impala doesn't support writing new data files containing complex type
> I think we reject some insert statements with complex types - how did these
I think we only block creating a Kudu table with complex types. In other cases, we allow creating tables (parquet/text) with complex types and as a result once can try inserting into such tables. The insert statement was not blocking such scenarios.
Since Impala can only have static types in the select list following CTAS statements also works. Although, the new_tab would not have any complex columns.
Create Table new_tab AS select * from table_with_complex_types.
http://gerrit.cloudera.org:8080/#/c/14634/1/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java:
http://gerrit.cloudera.org:8080/#/c/14634/1/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java@457
PS1, Line 457: "support writing new data files containing complex type columns",
> I would remove the bit about data files since this also applies to Kudu.
I changed it to "Impala doesn't support inserting into tables with complex type columns"
--
To view, visit http://gerrit.cloudera.org:8080/14634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81bd04b2f1cd9873462098f67a45cd3974094d96
Gerrit-Change-Number: 14634
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Nov 2019 18:48:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8692 Gracefully fail complex type inserts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14634 )
Change subject: IMPALA-8692 Gracefully fail complex type inserts
......................................................................
IMPALA-8692 Gracefully fail complex type inserts
Impala doesn't support writing new data files containing complex type
columns. Block such statements during analysis.
Added new tests in AnalyzeStmtsTest for the blocked scenarios.
Change-Id: I81bd04b2f1cd9873462098f67a45cd3974094d96
Reviewed-on: http://gerrit.cloudera.org:8080/14634
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
2 files changed, 18 insertions(+), 0 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I81bd04b2f1cd9873462098f67a45cd3974094d96
Gerrit-Change-Number: 14634
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>