You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2026/09/22 23:30:29 UTC

[PR] perf(setup): trim the setup family skills without changing behaviour [magpie]

potiuk opened a new pull request, #1353:
URL: https://github.com/apache/magpie/pull/1353

   ## Summary
   
   - Apply the `optimize-skill` recipe to the `setup` family, without changing what any skill does: 31,951 → 29,242 body tokens across seven skills (−8.5%), and the `setup` frontmatter (loaded in every session) from ~228 to ~167 tokens, under the 200-token budget.
   - Move Golden rules 7 and 9 out of `setup/SKILL.md`, byte-for-byte, into the sibling files that use them (`overrides.md`, `snapshot-model.md`); rule 8 stays because 12 places cite it.
   - Wording pass (one sentence per line, cut restatement) on `setup` plus isolated-setup-doctor / -verify / -update, upstream-fix, override-upstream and shared-config-sync.
   
   | skill | before | after |
   |---|---|---|
   | `setup` | 4,972 | 4,187 |
   | `setup-isolated-setup-verify` | 4,967 | 4,556 |
   | `setup-upstream-fix` | 4,614 | 4,245 |
   | `setup-shared-config-sync` | 4,185 | 3,836 |
   | `setup-isolated-setup-update` | 4,356 | 4,017 |
   | `setup-override-upstream` | 3,960 | 3,681 |
   | `setup-isolated-setup-doctor` | 4,897 | 4,720 |
   
   ## Type of change
   
   - [x] Skill change — no eval fixtures changed (no behaviour change)
   - [x] Documentation (`docs/mode-economics.md`, `docs/setup/marketplace.md` token figures)
   
   ## Test plan
   
   - [x] `prek run --all-files` passes (validator, lychee, surface-hash, token count, doc-sync)
   - [x] Mechanical invariant check against `main` for every rewritten file: frontmatter, pre-flight block, fenced code blocks, headings, golden-rule headlines and link targets identical; inline code spans preserved (whitespace-normalised). The only removed span is link text naming the deleted `docs/setup/install-recipes.md`, now matching its unchanged target.
   - [x] Eval suites for all seven skills, run on this branch and on `main` (outside the sandbox — the harness's `claude -p` exits 1 inside it):
   
   | suite | this branch | `main` |
   |---|---|---|
   | setup | 74/83 | same failing suites fail or flip on `main` (`preflight-floor` 2/8, `uninstall-default-set` 1/3) |
   | isolated-setup-doctor | 22/22 | — |
   | isolated-setup-verify | 9/14 | 10/14 |
   | isolated-setup-update | 14/15 | 13/15 |
   | upstream-fix | 8/8 | 8/8 |
   | override-upstream | 13/15 | 14/15 |
   | shared-config-sync | 12/12 | 12/12 |
   
   Every failure on this branch either fails on `main` too or is non-deterministic: re-running the branch-only failures (verify `step-1-classify` case-3 / case-6, override-upstream `step-0` case-3) passed them, and other cases in those steps failed instead. `step-m3` and `step-override-bypass` extract text this PR does not touch.
   
   ## RFC-AI-0004 compliance
   
   No behaviour change; every confirmation gate, "never" rule and placeholder is preserved.
   
   ## Linked issues
   
   Closes #1343. Part of #1342.
   
   ## Notes for reviewers
   
   - `setup`'s `surface_hash` changes (golden-rule callouts are fingerprinted with their file), so adopters who reconciled or overrode `setup` see one stale-configuration notice. The other six skills' hashes are unchanged.
   - Stale pointers fixed on the way: four rule-6 links aimed at `SKILL.md#golden-rules`, three link labels naming the deleted `install-recipes.md`, a doctor cross-reference to the wrong probe, a shared-config-sync pointer to a non-existent golden rule.
   - Eval-coupled inconsistencies found but deliberately left alone are listed in #1343.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] perf(setup): trim the setup family skills without changing behaviour [magpie]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #1353:
URL: https://github.com/apache/magpie/pull/1353


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org