You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2014/06/11 23:53:34 UTC

Review Request 22476: Escape TaskConfig in thermos UI

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22476/
-----------------------------------------------------------

Review request for Aurora, Mark Chu-Carroll and Brian Wickman.


Bugs: AURORA-523
    https://issues.apache.org/jira/browse/AURORA-523


Repository: aurora


Description
-------

Escape TaskConfig in thermos UI


Diffs
-----

  src/main/python/apache/thermos/observer/http/templates/rawtask.tpl c4b7f5283d06fe523ac7bf6ea268179df2a3a2c3 

Diff: https://reviews.apache.org/r/22476/diff/


Testing
-------

Tested with vagrant locally.


Thanks,

David McLaughlin


Re: Review Request 22476: Escape TaskConfig in thermos UI

Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22476/#review45643
-----------------------------------------------------------

Ship it!


Ship It!

- Joe Smith


On June 11, 2014, 2:53 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22476/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 2:53 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-523
>     https://issues.apache.org/jira/browse/AURORA-523
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Escape TaskConfig in thermos UI
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/observer/http/templates/rawtask.tpl c4b7f5283d06fe523ac7bf6ea268179df2a3a2c3 
> 
> Diff: https://reviews.apache.org/r/22476/diff/
> 
> 
> Testing
> -------
> 
> Tested with vagrant locally.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Re: Review Request 22476: Escape TaskConfig in thermos UI

Posted by Suman Karumuri <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22476/#review45434
-----------------------------------------------------------

Ship it!


Ship It!

- Suman Karumuri


On June 11, 2014, 9:53 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22476/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 9:53 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-523
>     https://issues.apache.org/jira/browse/AURORA-523
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Escape TaskConfig in thermos UI
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/observer/http/templates/rawtask.tpl c4b7f5283d06fe523ac7bf6ea268179df2a3a2c3 
> 
> Diff: https://reviews.apache.org/r/22476/diff/
> 
> 
> Testing
> -------
> 
> Tested with vagrant locally.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Re: Review Request 22476: Escape TaskConfig in thermos UI

Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22476/#review45804
-----------------------------------------------------------

Ship it!


Ship It!

- Brian Wickman


On June 11, 2014, 9:53 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22476/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 9:53 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-523
>     https://issues.apache.org/jira/browse/AURORA-523
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Escape TaskConfig in thermos UI
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/observer/http/templates/rawtask.tpl c4b7f5283d06fe523ac7bf6ea268179df2a3a2c3 
> 
> Diff: https://reviews.apache.org/r/22476/diff/
> 
> 
> Testing
> -------
> 
> Tested with vagrant locally.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Re: Review Request 22476: Escape TaskConfig in thermos UI

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22476/#review45436
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On June 11, 2014, 2:53 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22476/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 2:53 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-523
>     https://issues.apache.org/jira/browse/AURORA-523
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Escape TaskConfig in thermos UI
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/observer/http/templates/rawtask.tpl c4b7f5283d06fe523ac7bf6ea268179df2a3a2c3 
> 
> Diff: https://reviews.apache.org/r/22476/diff/
> 
> 
> Testing
> -------
> 
> Tested with vagrant locally.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>