You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Lars Kotthoff (JIRA)" <ji...@apache.org> on 2008/06/27 10:51:44 UTC

[jira] Created: (SOLR-610) Add support for hl.maxAnalyzedChars=-1 to highlight the whole field

Add support for hl.maxAnalyzedChars=-1 to highlight the whole field
-------------------------------------------------------------------

                 Key: SOLR-610
                 URL: https://issues.apache.org/jira/browse/SOLR-610
             Project: Solr
          Issue Type: New Feature
          Components: highlighter
         Environment: Tomcat 5.5
            Reporter: Lars Kotthoff
            Priority: Minor


Add support for specifying negative values for the hl.maxAnalyzedChars parameter to be able highlight the whole field without having to know its size.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-610) Add support for hl.maxAnalyzedChars=-1 to highlight the whole field

Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Klaas resolved SOLR-610.
-----------------------------

    Resolution: Fixed

commited.  Thanks lars!

> Add support for hl.maxAnalyzedChars=-1 to highlight the whole field
> -------------------------------------------------------------------
>
>                 Key: SOLR-610
>                 URL: https://issues.apache.org/jira/browse/SOLR-610
>             Project: Solr
>          Issue Type: New Feature
>          Components: highlighter
>    Affects Versions: 1.3
>         Environment: Tomcat 5.5
>            Reporter: Lars Kotthoff
>            Assignee: Mike Klaas
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-556-610.patch, SOLR-610-maxanalyzed.patch
>
>
> Add support for specifying negative values for the hl.maxAnalyzedChars parameter to be able highlight the whole field without having to know its size.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-610) Add support for hl.maxAnalyzedChars=-1 to highlight the whole field

Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608878#action_12608878 ] 

Mike Klaas commented on SOLR-610:
---------------------------------

Hi Lars,

I was planning on commiting SOLR-556.  Would you rather I commit that first, or to produce a unified patch instead?

-Mike

> Add support for hl.maxAnalyzedChars=-1 to highlight the whole field
> -------------------------------------------------------------------
>
>                 Key: SOLR-610
>                 URL: https://issues.apache.org/jira/browse/SOLR-610
>             Project: Solr
>          Issue Type: New Feature
>          Components: highlighter
>    Affects Versions: 1.3
>         Environment: Tomcat 5.5
>            Reporter: Lars Kotthoff
>            Priority: Minor
>         Attachments: SOLR-610-maxanalyzed.patch
>
>
> Add support for specifying negative values for the hl.maxAnalyzedChars parameter to be able highlight the whole field without having to know its size.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-610) Add support for hl.maxAnalyzedChars=-1 to highlight the whole field

Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Kotthoff updated SOLR-610:
-------------------------------

    Attachment: SOLR-556-610.patch

Attaching combined SOLR-556,610 patch. Submitting this one should be easier, as the changes for SOLR-610 can be made in an easier (and more efficient) way with SOLR-556 comitted. I think the SOLR-610 changes are small and non-intrusive enough to be sneaked in piggybacked on another patch ;)

> Add support for hl.maxAnalyzedChars=-1 to highlight the whole field
> -------------------------------------------------------------------
>
>                 Key: SOLR-610
>                 URL: https://issues.apache.org/jira/browse/SOLR-610
>             Project: Solr
>          Issue Type: New Feature
>          Components: highlighter
>    Affects Versions: 1.3
>         Environment: Tomcat 5.5
>            Reporter: Lars Kotthoff
>            Priority: Minor
>         Attachments: SOLR-556-610.patch, SOLR-610-maxanalyzed.patch
>
>
> Add support for specifying negative values for the hl.maxAnalyzedChars parameter to be able highlight the whole field without having to know its size.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SOLR-610) Add support for hl.maxAnalyzedChars=-1 to highlight the whole field

Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Kotthoff closed SOLR-610.
------------------------------


> Add support for hl.maxAnalyzedChars=-1 to highlight the whole field
> -------------------------------------------------------------------
>
>                 Key: SOLR-610
>                 URL: https://issues.apache.org/jira/browse/SOLR-610
>             Project: Solr
>          Issue Type: New Feature
>          Components: highlighter
>    Affects Versions: 1.3
>         Environment: Tomcat 5.5
>            Reporter: Lars Kotthoff
>            Assignee: Mike Klaas
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-556-610.patch, SOLR-610-maxanalyzed.patch
>
>
> Add support for specifying negative values for the hl.maxAnalyzedChars parameter to be able highlight the whole field without having to know its size.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-610) Add support for hl.maxAnalyzedChars=-1 to highlight the whole field

Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Klaas updated SOLR-610:
----------------------------

    Fix Version/s: 1.3

> Add support for hl.maxAnalyzedChars=-1 to highlight the whole field
> -------------------------------------------------------------------
>
>                 Key: SOLR-610
>                 URL: https://issues.apache.org/jira/browse/SOLR-610
>             Project: Solr
>          Issue Type: New Feature
>          Components: highlighter
>    Affects Versions: 1.3
>         Environment: Tomcat 5.5
>            Reporter: Lars Kotthoff
>            Assignee: Mike Klaas
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-556-610.patch, SOLR-610-maxanalyzed.patch
>
>
> Add support for specifying negative values for the hl.maxAnalyzedChars parameter to be able highlight the whole field without having to know its size.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (SOLR-610) Add support for hl.maxAnalyzedChars=-1 to highlight the whole field

Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Klaas reassigned SOLR-610:
-------------------------------

    Assignee: Mike Klaas

> Add support for hl.maxAnalyzedChars=-1 to highlight the whole field
> -------------------------------------------------------------------
>
>                 Key: SOLR-610
>                 URL: https://issues.apache.org/jira/browse/SOLR-610
>             Project: Solr
>          Issue Type: New Feature
>          Components: highlighter
>    Affects Versions: 1.3
>         Environment: Tomcat 5.5
>            Reporter: Lars Kotthoff
>            Assignee: Mike Klaas
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-556-610.patch, SOLR-610-maxanalyzed.patch
>
>
> Add support for specifying negative values for the hl.maxAnalyzedChars parameter to be able highlight the whole field without having to know its size.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-610) Add support for hl.maxAnalyzedChars=-1 to highlight the whole field

Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Kotthoff updated SOLR-610:
-------------------------------

    Affects Version/s: 1.3

> Add support for hl.maxAnalyzedChars=-1 to highlight the whole field
> -------------------------------------------------------------------
>
>                 Key: SOLR-610
>                 URL: https://issues.apache.org/jira/browse/SOLR-610
>             Project: Solr
>          Issue Type: New Feature
>          Components: highlighter
>    Affects Versions: 1.3
>         Environment: Tomcat 5.5
>            Reporter: Lars Kotthoff
>            Priority: Minor
>         Attachments: SOLR-610-maxanalyzed.patch
>
>
> Add support for specifying negative values for the hl.maxAnalyzedChars parameter to be able highlight the whole field without having to know its size.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-610) Add support for hl.maxAnalyzedChars=-1 to highlight the whole field

Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Kotthoff updated SOLR-610:
-------------------------------

    Attachment: SOLR-610-maxanalyzed.patch

Patch adding the described feature and a unit test for it. Also using highlighter.setMaxDocCharsToAnalyze instead of the deprecated highlighter.setMaxDocBytesToAnalyze to tell Lucene how many characters to analyze.

This patch clashes with the changes in SOLR-556, I'll be happy to provide a patch which covers both issues if required.

> Add support for hl.maxAnalyzedChars=-1 to highlight the whole field
> -------------------------------------------------------------------
>
>                 Key: SOLR-610
>                 URL: https://issues.apache.org/jira/browse/SOLR-610
>             Project: Solr
>          Issue Type: New Feature
>          Components: highlighter
>    Affects Versions: 1.3
>         Environment: Tomcat 5.5
>            Reporter: Lars Kotthoff
>            Priority: Minor
>         Attachments: SOLR-610-maxanalyzed.patch
>
>
> Add support for specifying negative values for the hl.maxAnalyzedChars parameter to be able highlight the whole field without having to know its size.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.