[GitHub] lucene-solr pull request #:

[dsmiley <gi...@git.apache.org>]

Github user dsmiley commented on the pull request:

    https://github.com/apache/lucene-solr/commit/43d7f5d104802bc3281d5995c6c2d71bebf1f369#commitcomment-31096103
  
    isNestedAtomicUpdate seems to return true even it it isn't an atomic update.  So it's name isn't right or the method is doing too much at once (i.e. should be split up?).  I'm not sure why it's needed -- I mean I see where you're calling it but I don't follow the rationale for its existence.  'course the overall code in this class is hideously complicated even before we came along so that doesn't help ;-)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org