You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/02/03 05:29:51 UTC
[kudu-CR] [consensus] cleanup on TimeManager
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15150
Change subject: [consensus] cleanup on TimeManager
......................................................................
[consensus] cleanup on TimeManager
A tiny cleanup:
* removed outdated TODO TimeManager::WaitUntilSafe()
* removed questinable PREDICT_FALSE() and its extra 'if ()' scope
I also thought of replacing std::vector with std::deque as the container
for TimeManager::waiters_, but I'm not sure it's worth it given the
expected number of elements in there.
Change-Id: I1315e058b4a8e0518c96fad6454aeb4d0a46b2e6
---
M src/kudu/consensus/time_manager.cc
M src/kudu/consensus/time_manager.h
2 files changed, 9 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/15150/1
--
To view, visit http://gerrit.cloudera.org:8080/15150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1315e058b4a8e0518c96fad6454aeb4d0a46b2e6
Gerrit-Change-Number: 15150
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [consensus] cleanup on TimeManager
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15150 )
Change subject: [consensus] cleanup on TimeManager
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1315e058b4a8e0518c96fad6454aeb4d0a46b2e6
Gerrit-Change-Number: 15150
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 03 Feb 2020 17:47:07 +0000
Gerrit-HasComments: No
[kudu-CR] [consensus] cleanup on TimeManager
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15150
to look at the new patch set (#2).
Change subject: [consensus] cleanup on TimeManager
......................................................................
[consensus] cleanup on TimeManager
A tiny cleanup:
* removed outdated TODO TimeManager::WaitUntilSafe()
* removed questionable PREDICT_FALSE() and its extra 'if ()' scope
I also thought of replacing std::vector with std::deque as the container
for TimeManager::waiters_, but I'm not sure it's worth it given the
expected number of elements in there.
Change-Id: I1315e058b4a8e0518c96fad6454aeb4d0a46b2e6
---
M src/kudu/consensus/time_manager.cc
M src/kudu/consensus/time_manager.h
2 files changed, 9 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/15150/2
--
To view, visit http://gerrit.cloudera.org:8080/15150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1315e058b4a8e0518c96fad6454aeb4d0a46b2e6
Gerrit-Change-Number: 15150
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [consensus] cleanup on TimeManager
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15150 )
Change subject: [consensus] cleanup on TimeManager
......................................................................
[consensus] cleanup on TimeManager
A tiny cleanup:
* removed outdated TODO TimeManager::WaitUntilSafe()
* removed questionable PREDICT_FALSE() and its extra 'if ()' scope
I also thought of replacing std::vector with std::deque as the container
for TimeManager::waiters_, but I'm not sure it's worth it given the
expected number of elements in there.
Change-Id: I1315e058b4a8e0518c96fad6454aeb4d0a46b2e6
Reviewed-on: http://gerrit.cloudera.org:8080/15150
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/consensus/time_manager.cc
M src/kudu/consensus/time_manager.h
2 files changed, 9 insertions(+), 14 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1315e058b4a8e0518c96fad6454aeb4d0a46b2e6
Gerrit-Change-Number: 15150
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [consensus] cleanup on TimeManager
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15150 )
Change subject: [consensus] cleanup on TimeManager
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15150/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15150/1//COMMIT_MSG@11
PS1, Line 11: questinable
> questionable
Done
--
To view, visit http://gerrit.cloudera.org:8080/15150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1315e058b4a8e0518c96fad6454aeb4d0a46b2e6
Gerrit-Change-Number: 15150
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 03 Feb 2020 15:26:15 +0000
Gerrit-HasComments: Yes
[kudu-CR] [consensus] cleanup on TimeManager
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15150 )
Change subject: [consensus] cleanup on TimeManager
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15150/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15150/1//COMMIT_MSG@11
PS1, Line 11: questinable
questionable
--
To view, visit http://gerrit.cloudera.org:8080/15150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1315e058b4a8e0518c96fad6454aeb4d0a46b2e6
Gerrit-Change-Number: 15150
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 03 Feb 2020 07:31:02 +0000
Gerrit-HasComments: Yes