You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Paul Brett <pa...@twopensource.com> on 2015/10/02 01:17:39 UTC
Re: Review Request 38287: Check if the futrue is failed before
dispatch in freeze()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38287/#review101290
-----------------------------------------------------------
LGTM
- Paul Brett
On Sept. 24, 2015, 3:15 a.m., Jian Qiu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38287/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 3:15 a.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, and Paul Brett.
>
>
> Bugs: MESOS-3272
> https://issues.apache.org/jira/browse/MESOS-3272
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_FreezeNonFreezer, the freezer process is terminated in it initilize method, which causes the core dump when cgroups::freezer::freeze() calls dispatch(freezer, &internal::Freezer::freeze).
>
> This check is added in cgroups::freezer::freeze() to avoid calling dispatch if the freezer process is terminated.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f
>
> Diff: https://reviews.apache.org/r/38287/diff/
>
>
> Testing
> -------
>
> ./mesos-tests.sh --gtest_filter="CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_FreezeNonFreezer" --gtest_repeat=1000 --gtest_break_on_failure
>
>
> Thanks,
>
> Jian Qiu
>
>