You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/22 13:41:03 UTC
[GitHub] [incubator-nuttx] zouboan opened a new pull request, #7658: tools/Config:Fix error caused by double quotation in Windows native build
zouboan opened a new pull request, #7658:
URL: https://github.com/apache/incubator-nuttx/pull/7658
## Summary
**This commit belong to PR#7572 in the past, but there's conflict with PR#7552 when ever rabse**
tools/Config:Fix some error caused by double quotation in Windows native build:
The result of $(subst "X",,${shell $(INCDIR) "$(CC)" "X"}) will left an space double quotation:
-isystem ""G:\NuttX\nuttx/include -D__NuttX__ -D__KERNEL__ -pipe -I ""G:\NuttX\nuttx/libs/libc
## Impact
Windows native build
## Testing
stm32f4discovery in Windows XP/7 native build GnuWin32 + MinGW + kconfig-frontends-win32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7658: tools/Config:Fix error caused by double quotation in Windows native build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7658:
URL: https://github.com/apache/incubator-nuttx/pull/7658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] zouboan commented on pull request #7658: tools/Config:Fix error caused by double quotation in Windows native build
Posted by GitBox <gi...@apache.org>.
zouboan commented on PR #7658:
URL: https://github.com/apache/incubator-nuttx/pull/7658#issuecomment-1324424313
> Hi @zouboan did you test your modification on Windows directories with white space?
Thanks for your remind, i tried to add white space in directories name, both Linux and Windows auto dismiss prefix and suffix white space in directories name, when i add white space in middle of directories name, both Linux and Windows failed in configure stage, **even before this patch** for example, when i add white space in boards/arm/stm32/stm32f4discovery/configs/n` `sh will give error:
`Directory for stm32f4discovery:n does not exist.`
when i add white space in apps/examples/he` `llo will give error:
```
./NuttX/apps/examples/Make.defs:21: /home/cast504/E/NuttX/apps/examples/he: No such file or directory
./NuttX/apps/examples/Make.defs:21: llo/Make.defs: No such file or directory
make[2]: *** No rule to make target 'llo/Make.defs'. Stop.
```
both in Linux and Windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #7658: tools/Config:Fix error caused by double quotation in Windows native build
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #7658:
URL: https://github.com/apache/incubator-nuttx/pull/7658#issuecomment-1324165239
Hi @zouboan did you test your modification on Windows directories with white space?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org