[GitHub] [knox] smolnar82 commented on pull request #347: KNOX-2387 - SameSite fix for hadoop-jwt cookie

[GitBox <gi...@apache.org>]

smolnar82 commented on pull request #347:
URL: https://github.com/apache/knox/pull/347#issuecomment-645158025


   So, as far as I understood Chrome made the default behavior more secure by setting the default to `Lax`. With this change, we blindly set this to `None` to be backward compatible. At least, I'd introduce a provider parameter for this purpose to allow end-users to control it like this:
   
   1. in the `init()` method I'd parse the newly introduced `knoxsso.cookie.samesite` and save it to a class member
   2. in `addJWTHadoopCookie` I'd check if it's set and use the custom value or default to `None`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org