You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by an...@apache.org on 2020/05/26 13:34:25 UTC
svn commit: r1878120 - in
/jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security:
authorization/permission/ privilege/ user/
Author: angela
Date: Tue May 26 13:34:25 2020
New Revision: 1878120
URL: http://svn.apache.org/viewvc?rev=1878120&view=rev
Log:
OAK-9075 : Remove unnecessary (un)boxing in oak-exercise (patch provided by Lars Grefer)
Modified:
jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/authorization/permission/L4_PrivilegesAndPermissionsTest.java
jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/privilege/L4_CustomPrivilegeTest.java
jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/user/L13_SystemUserTest.java
jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/user/L3_UserVsPrincipalTest.java
Modified: jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/authorization/permission/L4_PrivilegesAndPermissionsTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/authorization/permission/L4_PrivilegesAndPermissionsTest.java?rev=1878120&r1=1878119&r2=1878120&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/authorization/permission/L4_PrivilegesAndPermissionsTest.java (original)
+++ jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/authorization/permission/L4_PrivilegesAndPermissionsTest.java Tue May 26 13:34:25 2020
@@ -390,7 +390,7 @@ public class L4_PrivilegesAndPermissions
Session userSession = createTestSession();
for (String nonExistingItemPath : pathHasPermission.keySet()) {
- boolean hasPermission = pathHasPermission.get(nonExistingItemPath).booleanValue();
+ boolean hasPermission = pathHasPermission.get(nonExistingItemPath);
assertEquals(hasPermission, userSession.hasPermission(nonExistingItemPath, Session.ACTION_REMOVE));
}
Modified: jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/privilege/L4_CustomPrivilegeTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/privilege/L4_CustomPrivilegeTest.java?rev=1878120&r1=1878119&r2=1878120&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/privilege/L4_CustomPrivilegeTest.java (original)
+++ jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/privilege/L4_CustomPrivilegeTest.java Tue May 26 13:34:25 2020
@@ -139,7 +139,7 @@ public class L4_CustomPrivilegeTest exte
assertEqualPrivileges(expected, customAggrPriv.getAggregatePrivileges());
Boolean expectedIsAbstract = null; // EXERCISE
- assertEquals(expectedIsAbstract.booleanValue(), customAggrPriv.isAbstract());
+ assertEquals(expectedIsAbstract, customAggrPriv.isAbstract());
}
@Test
Modified: jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/user/L13_SystemUserTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/user/L13_SystemUserTest.java?rev=1878120&r1=1878119&r2=1878120&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/user/L13_SystemUserTest.java (original)
+++ jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/user/L13_SystemUserTest.java Tue May 26 13:34:25 2020
@@ -137,10 +137,10 @@ public class L13_SystemUserTest extends
Authorizable authorizable = userMgr.getAuthorizable(systemUser.getID());
Boolean isGroup = null; // EXERCISE
- assertEquals(isGroup.booleanValue(), authorizable.isGroup());
+ assertEquals(isGroup, authorizable.isGroup());
Boolean isAdmin = null; // EXERCISE
- assertEquals(isAdmin.booleanValue(), systemUser.isAdmin());
+ assertEquals(isAdmin, systemUser.isAdmin());
// EXERCISE: retrieve the authorizable by class: what is the correct authorizble-class to use?
Class cls = null;
Modified: jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/user/L3_UserVsPrincipalTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/user/L3_UserVsPrincipalTest.java?rev=1878120&r1=1878119&r2=1878120&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/user/L3_UserVsPrincipalTest.java (original)
+++ jackrabbit/oak/trunk/oak-exercise/src/test/java/org/apache/jackrabbit/oak/exercise/security/user/L3_UserVsPrincipalTest.java Tue May 26 13:34:25 2020
@@ -194,7 +194,7 @@ public class L3_UserVsPrincipalTest exte
root.commit();
Boolean expectedEquals = null; // EXERCISE
- assertEquals(expectedEquals.booleanValue(), testUser.equals(user2));
+ assertEquals(expectedEquals, testUser.equals(user2));
} finally {
if (user2 != null) {