You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vy...@gmail.com> on 2015/03/24 19:22:37 UTC

Review Request 32449: Patch for SQOOP-2113

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32449/
-----------------------------------------------------------

Review request for Sqoop and Jarek Cecho.


Bugs: SQOOP-2113
    https://issues.apache.org/jira/browse/SQOOP-2113


Repository: sqoop-sqoop2


Description
-------

see jira


Diffs
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 81c7558 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java ee0f3f0 
  client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 0783002 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 882c336 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 0561ade 
  common/src/main/java/org/apache/sqoop/json/JobConfigInputBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/JsonBean.java 1dd275e 
  common/src/main/java/org/apache/sqoop/json/LinkBean.java 2e2406f 
  common/src/main/java/org/apache/sqoop/json/LinkConfigInputBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 1b1ec28 
  common/src/main/java/org/apache/sqoop/model/ConfigUtils.java dd6e9ce 
  common/src/main/java/org/apache/sqoop/model/MStringInput.java 7365098 
  common/src/main/java/org/apache/sqoop/model/ModelError.java 17e70df 
  common/src/test/java/org/apache/sqoop/json/TestJobConfigInputBean.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/json/TestLinkConfigInputBean.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java fbc7faa 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java c09b77b 
  repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 039524a 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java b889b85 
  server/src/main/java/org/apache/sqoop/handler/ConfigInputRequestHandler.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/server/common/ServerError.java c68ab57 
  server/src/main/java/org/apache/sqoop/server/v1/ConfigInputServlet.java PRE-CREATION 
  server/src/main/webapp/WEB-INF/web.xml 60ee8c4 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 94e8c7a 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java b5baf87 

Diff: https://reviews.apache.org/r/32449/diff/


Testing
-------


Thanks,

Veena Basavaraj


Re: Review Request 32449: Patch for SQOOP-2113

Posted by Veena Basavaraj <vy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32449/
-----------------------------------------------------------

(Updated March 24, 2015, 8:07 p.m.)


Review request for Sqoop and Jarek Cecho.


Bugs: SQOOP-2113
    https://issues.apache.org/jira/browse/SQOOP-2113


Repository: sqoop-sqoop2


Description (updated)
-------

see jira

partial reviews were done in

https://reviews.apache.org/r/31173/

the discussions on the semantics of api happened on dev@
the wiki doc : https://cwiki.apache.org/confluence/display/SQOOP/Sqoop+Config+as+Top+Level+Entity#SqoopConfigasTopLevelEntity-RestAPIchanges


Diffs
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 81c7558 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java ee0f3f0 
  client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 0783002 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 882c336 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 0561ade 
  common/src/main/java/org/apache/sqoop/json/JobConfigInputBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/JsonBean.java 1dd275e 
  common/src/main/java/org/apache/sqoop/json/LinkBean.java 2e2406f 
  common/src/main/java/org/apache/sqoop/json/LinkConfigInputBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 1b1ec28 
  common/src/main/java/org/apache/sqoop/model/ConfigUtils.java dd6e9ce 
  common/src/main/java/org/apache/sqoop/model/MStringInput.java 7365098 
  common/src/main/java/org/apache/sqoop/model/ModelError.java 17e70df 
  common/src/test/java/org/apache/sqoop/json/TestJobConfigInputBean.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/json/TestLinkConfigInputBean.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java fbc7faa 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java c09b77b 
  repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 039524a 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java b889b85 
  server/src/main/java/org/apache/sqoop/handler/ConfigInputRequestHandler.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/server/common/ServerError.java c68ab57 
  server/src/main/java/org/apache/sqoop/server/v1/ConfigInputServlet.java PRE-CREATION 
  server/src/main/webapp/WEB-INF/web.xml 60ee8c4 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 94e8c7a 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java b5baf87 

Diff: https://reviews.apache.org/r/32449/diff/


Testing
-------


Thanks,

Veena Basavaraj


Re: Review Request 32449: Patch for SQOOP-2113

Posted by Veena Basavaraj <vy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32449/
-----------------------------------------------------------

(Updated March 24, 2015, 11:25 a.m.)


Review request for Sqoop and Jarek Cecho.


Bugs: SQOOP-2113
    https://issues.apache.org/jira/browse/SQOOP-2113


Repository: sqoop-sqoop2


Description (updated)
-------

see jira

partial reviews were done in

https://reviews.apache.org/r/31173/


Diffs
-----

  client/src/main/java/org/apache/sqoop/client/SqoopClient.java 81c7558 
  client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java ee0f3f0 
  client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 0783002 
  client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 882c336 
  common/src/main/java/org/apache/sqoop/json/JobBean.java 0561ade 
  common/src/main/java/org/apache/sqoop/json/JobConfigInputBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/JsonBean.java 1dd275e 
  common/src/main/java/org/apache/sqoop/json/LinkBean.java 2e2406f 
  common/src/main/java/org/apache/sqoop/json/LinkConfigInputBean.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 1b1ec28 
  common/src/main/java/org/apache/sqoop/model/ConfigUtils.java dd6e9ce 
  common/src/main/java/org/apache/sqoop/model/MStringInput.java 7365098 
  common/src/main/java/org/apache/sqoop/model/ModelError.java 17e70df 
  common/src/test/java/org/apache/sqoop/json/TestJobConfigInputBean.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/json/TestLinkConfigInputBean.java PRE-CREATION 
  common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java fbc7faa 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java c09b77b 
  repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 039524a 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java b889b85 
  server/src/main/java/org/apache/sqoop/handler/ConfigInputRequestHandler.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/server/common/ServerError.java c68ab57 
  server/src/main/java/org/apache/sqoop/server/v1/ConfigInputServlet.java PRE-CREATION 
  server/src/main/webapp/WEB-INF/web.xml 60ee8c4 
  test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 94e8c7a 
  test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java b5baf87 

Diff: https://reviews.apache.org/r/32449/diff/


Testing
-------


Thanks,

Veena Basavaraj