[jira] [Commented] (HBASE-11437) Modify cell tag handling code to treat the length as unsigned

["Anoop Sam John (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053863#comment-14053863 ] 

Anoop Sam John commented on HBASE-11437:
----------------------------------------

IMO, Cell#getTagsLength() can be kept as deprecated in 0.98.x and 0.99 and can be removed from master (2.0.0).   What do you say?

> Modify cell tag handling code to treat the length as unsigned
> -------------------------------------------------------------
>
>                 Key: HBASE-11437
>                 URL: https://issues.apache.org/jira/browse/HBASE-11437
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.98.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.99.0, 0.98.5, 2.0.0
>
>         Attachments: HBASE-11437.patch
>
>
> We store each tag's length and total tags length with 2 bytes in KeyValue buffer, HFiles etc and we treat these lengths as short through out the code.  So the max length can be Short.MAX_VALUE.   We can treat these lengths as unsigned and +ve always.  So we can actually treat these lengths as int and store with 2 bytes so that the max length can reach 65535.



--
This message was sent by Atlassian JIRA
(v6.2#6252)