You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/06/09 06:25:22 UTC

[GitHub] [camel-quarkus] jamesnetherton opened a new issue #2752: Avoid duplicating code in `org.apache.camel.quarkus.core.BaseModel`

jamesnetherton opened a new issue #2752:
URL: https://github.com/apache/camel-quarkus/issues/2752


   The overhead of maintaining `BaseModel` is such that we often miss critical changes in Camel that need to be sync'd back to our implementation.
   
   We should try to find a solution to avoid having to duplicate and sync code from Camel. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on issue #2752: Avoid duplicating code in `org.apache.camel.quarkus.core.BaseModel`

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #2752:
URL: https://github.com/apache/camel-quarkus/issues/2752#issuecomment-858452427


   > Maybe we can just remove FastModel/BaseModel and we can introduce it only if when it is needed ?
   
   Yes, makes sense.
   
   > I think that would be fine as far as I remember, most of the time it is about to provide specif implementation or some service/factory-finders.
   
   Thanks - I'll investigate further. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] lburgazzoli commented on issue #2752: Avoid duplicating code in `org.apache.camel.quarkus.core.BaseModel`

Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #2752:
URL: https://github.com/apache/camel-quarkus/issues/2752#issuecomment-858445709


   > I don't see anything in `org.apache.camel.quarkus.core.BaseModel` that is special or optimized for camel-quarkus so we could make `FastModel` extend `DefaultModel` and if we ever need to do customizations, then we do them in `FastModel`.
   > 
   
   Maybe we can just remove FastModel/BaseModel and we can introduce it only if when it is needed ?
   
   > How should we handle `FastCamelContext`? Extend `DefaultCamelContext` and keep our CQ specific overrides? Or is there a better way?
   
   I think that would be fine as far as I remember, most of the time it is about to provide specif implementation or some service/factory-finders. If we'll find out that we need some specific hooks, we may think to enhance the *CamelContext in Camel so we don't need copy and paste nay more.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] lburgazzoli commented on issue #2752: Avoid duplicating code in `org.apache.camel.quarkus.core.BaseModel`

Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #2752:
URL: https://github.com/apache/camel-quarkus/issues/2752#issuecomment-857446177


   Same may apply to the FastCamelContext


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton closed issue #2752: Avoid duplicating code in `org.apache.camel.quarkus.core.BaseModel`

Posted by GitBox <gi...@apache.org>.
jamesnetherton closed issue #2752:
URL: https://github.com/apache/camel-quarkus/issues/2752


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on issue #2752: Avoid duplicating code in `org.apache.camel.quarkus.core.BaseModel`

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #2752:
URL: https://github.com/apache/camel-quarkus/issues/2752#issuecomment-858431857


   I don't see anything in `org.apache.camel.quarkus.core.BaseModel` that is special or optimized for camel-quarkus so we could make `FastModel` extend `DefaultModel` and if we ever need to do customizations, then we do them in `FastModel`.
   
   How should we handle `FastCamelContext`? Extend `DefaultCamelContext` and keep our CQ specific overrides? Or is there a better way?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org