You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Tommy Stendahl (JIRA)" <ji...@apache.org> on 2018/07/02 14:34:00 UTC

[jira] [Comment Edited] (CASSANDRA-14419) Resume compresed hints delivery broken

    [ https://issues.apache.org/jira/browse/CASSANDRA-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530002#comment-16530002 ] 

Tommy Stendahl edited comment on CASSANDRA-14419 at 7/2/18 2:33 PM:
--------------------------------------------------------------------

[~iamaleksey] thanks for the review.

I don't think we need the base class {{AlteredHints}} so I moved the relevant changes into {{HintsCompressionTest}}. I updated my branch with a commit for this, [cassandra-14419-30|https://github.com/tommystendahl/cassandra/tree/cassandra-14419-30].

For {{HintsServiceTest}} do you think I should backport the complete patch for CASSANDRA-12016 or should I copy the bare minimum needed for {{HintsServiceTest}}? It's relatively easy to backport the complete patch and I can't see any side effects except that part of it isn't needed for {{HintsServiceTest}}.


was (Author: tommy_s):
Thanks for the review.

I don't think we need the base class {{AlteredHints}} so I moved the relevant changes into {{HintsCompressionTest}}. I updated my branch with a commit for this, [cassandra-14419-30|https://github.com/tommystendahl/cassandra/tree/cassandra-14419-30].

For {{HintsServiceTest}} do you think I should backport the complete patch for CASSANDRA-12016 or should I copy the bare minimum needed for {{HintsServiceTest}}? It's relatively easy to backport the complete patch and I can't see any side effects except that part of it isn't needed for {{HintsServiceTest}}.

> Resume compresed hints delivery broken
> --------------------------------------
>
>                 Key: CASSANDRA-14419
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14419
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Hints
>            Reporter: Tommy Stendahl
>            Assignee: Tommy Stendahl
>            Priority: Blocker
>             Fix For: 3.0.17
>
>
> We are using Cassandra 3.0.15 and are using compressed hints, but if hint delivery is interrupted resuming hint delivery is failing.
> {code}
> 2018-04-04T13:27:48.948+0200 ERROR [HintsDispatcher:14] CassandraDaemon.java:207 Exception in thread Thread[HintsDispatcher:14,1,main]
> java.lang.IllegalArgumentException: Unable to seek to position 1789149057 in /var/lib/cassandra/hints/9592c860-1054-4c60-b3b8-faa9adc6d769-1522838912649-1.hints (118259682 bytes) in read-only mode
>         at org.apache.cassandra.io.util.RandomAccessReader.seek(RandomAccessReader.java:287) ~[apache-cassandra-clientutil-3.0.15.jar:3.0.15]
>         at org.apache.cassandra.hints.HintsReader.seek(HintsReader.java:114) ~[apache-cassandra-3.0.15.jar:3.0.15]
>         at org.apache.cassandra.hints.HintsDispatcher.seek(HintsDispatcher.java:83) ~[apache-cassandra-3.0.15.jar:3.0.15]
>         at org.apache.cassandra.hints.HintsDispatchExecutor$DispatchHintsTask.deliver(HintsDispatchExecutor.java:263) ~[apache-cassandra-3.0.15.jar:3.0.15]
>         at org.apache.cassandra.hints.HintsDispatchExecutor$DispatchHintsTask.dispatch(HintsDispatchExecutor.java:248) ~[apache-cassandra-3.0.15.jar:3.0.15]
>         at org.apache.cassandra.hints.HintsDispatchExecutor$DispatchHintsTask.dispatch(HintsDispatchExecutor.java:226) ~[apache-cassandra-3.0.15.jar:3.0.15]
>         at org.apache.cassandra.hints.HintsDispatchExecutor$DispatchHintsTask.run(HintsDispatchExecutor.java:205) ~[apache-cassandra-3.0.15.jar:3.0.15]
>         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[na:1.8.0_152]
>         at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[na:1.8.0_152]
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[na:1.8.0_152]
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [na:1.8.0_152]
>         at org.apache.cassandra.concurrent.NamedThreadFactory.lambda$threadLocalDeallocator$0(NamedThreadFactory.java:79) [apache-cassandra-3.0.15.jar:3.0.15]
>         at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_152]
> {code}
>  I think the problem is similar to CASSANDRA-11960.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org