Re: [PR] [HUDI-8111] Adding support to validate last N file slices with HoodieMetadataValidator [hudi]

["yihua (via GitHub)" <gi...@apache.org>]

yihua commented on code in PR #11864:
URL: https://github.com/apache/hudi/pull/11864#discussion_r1844593798


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java:
##########
@@ -1136,6 +1151,11 @@ private void validateFileSlices(
           mismatch = true;
           break;
         }
+        // test for log files equality
+        if (!fileSlice1.getLogFiles().collect(Collectors.toList()).equals(fileSlice2.getLogFiles().collect(Collectors.toList()))) {

Review Comment:
   This bug is fixed in #12141.



##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java:
##########
@@ -1136,6 +1151,11 @@ private void validateFileSlices(
           mismatch = true;
           break;
         }
+        // test for log files equality
+        if (!fileSlice1.getLogFiles().collect(Collectors.toList()).equals(fileSlice2.getLogFiles().collect(Collectors.toList()))) {

Review Comment:
   This introduced a bug that overshadows the logic in `areFileSliceCommittedLogFilesMatching`, causing false positives.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org