You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/30 16:24:19 UTC

[GitHub] lupesko commented on issue #12374: Fix/public internal header

lupesko commented on issue #12374: Fix/public internal header
URL: https://github.com/apache/incubator-mxnet/pull/12374#issuecomment-417380306
 
 
   > public headers should only define interfaces and should include internal dependencies as it allows users to access non-exposed interfaces
   
   @azai91 did you mean "...and should not include internal dependencies..." ?
   
   @apeforest @samskalicky @anirudh2290 can you please take a look?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services