You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2016/06/04 04:32:51 UTC
incubator-zeppelin git commit: ZEPPELIN-930 ] fix width and not close
li tag in searchbar
Repository: incubator-zeppelin
Updated Branches:
refs/heads/master afb1214c2 -> c4170b543
ZEPPELIN-930 ] fix width and not close li tag in searchbar
### What is this PR for?
closed li tag.
and Add a tooltip, and reduced the size of the horizontal search bar.
### What type of PR is it?
Bug Fix and Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-930
### How should this be tested?
It changes the browser horizontal size.
Use the search feature.
### Screenshots (if appropriate)
#### before
#### after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: CloverHearts <cl...@gmail.com>
Closes #938 from cloverhearts/fix/ZEPPELIN-930 and squashes the following commits:
bd0fca2 [CloverHearts] change placeholder text on search box.
17573c0 [CloverHearts] reverting placeholder in search box on navbar.
d2fbba7 [CloverHearts] Merge branch 'master' into fix/ZEPPELIN-930
0bd1785 [CloverHearts] fix width and not close li tag in searchbar
Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/c4170b54
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/c4170b54
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/c4170b54
Branch: refs/heads/master
Commit: c4170b5431dd49caa7ce17494e202aba9ee30ec6
Parents: afb1214
Author: CloverHearts <cl...@gmail.com>
Authored: Thu Jun 2 14:20:04 2016 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Fri Jun 3 21:34:10 2016 -0700
----------------------------------------------------------------------
zeppelin-web/src/components/navbar/navbar.html | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/c4170b54/zeppelin-web/src/components/navbar/navbar.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/components/navbar/navbar.html b/zeppelin-web/src/components/navbar/navbar.html
index 148d67d..5a8e0cd 100644
--- a/zeppelin-web/src/components/navbar/navbar.html
+++ b/zeppelin-web/src/components/navbar/navbar.html
@@ -65,15 +65,17 @@ limitations under the License.
<li ng-if="ticket">
<!--TODO(bzz): move to Typeahead https://angular-ui.github.io/bootstrap -->
<form role="search"
- style="width: 300px; display: inline-block; margin: 0 10px"
+ style="display: inline-block; margin: 0 10px"
+ class="navbar-form"
ng-submit="search(searchTerm)">
<div class="input-group">
<input
type="text"
+ style="min-width:300px;"
ng-model="searchTerm"
ng-disabled="!navbar.connected"
class="form-control"
- placeholder="Search in your notebooks"
+ placeholder="Search your Notebooks"
/>
<span class="input-group-btn">
<button
@@ -86,6 +88,7 @@ limitations under the License.
</span>
</div>
</form>
+ </li>
<li class="server-status" >
<i class="fa fa-circle" ng-class="{'server-connected':navbar.connected, 'server-disconnected':!navbar.connected}"></i>
<span ng-show="navbar.connected" ng-if="ticket.principal == 'anonymous' ">Connected</span>