You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "nanfeng1999 (via GitHub)" <gi...@apache.org> on 2023/12/18 02:49:47 UTC

[PR] [fix](block) add block columns size dcheck [doris]

nanfeng1999 opened a new pull request, #28539:
URL: https://github.com/apache/doris/pull/28539

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28539:
URL: https://github.com/apache/doris/pull/28539#issuecomment-1859476159

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28539:
URL: https://github.com/apache/doris/pull/28539#issuecomment-1862390189

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.53 seconds
    stream load tsv:          569 seconds loaded 74807831229 Bytes, about 125 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          66 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.5 seconds inserted 10000000 Rows, about 350K ops/s
    storage size: 17183675210 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "nanfeng1999 (via GitHub)" <gi...@apache.org>.
nanfeng1999 commented on PR #28539:
URL: https://github.com/apache/doris/pull/28539#issuecomment-1865742874

   run arm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "nanfeng1999 (via GitHub)" <gi...@apache.org>.
nanfeng1999 commented on PR #28539:
URL: https://github.com/apache/doris/pull/28539#issuecomment-1863952803

   run arm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28539:
URL: https://github.com/apache/doris/pull/28539#issuecomment-1859471232

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28539:
URL: https://github.com/apache/doris/pull/28539#issuecomment-1868159876

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28539:
URL: https://github.com/apache/doris/pull/28539#issuecomment-1868204971

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit e1675bbc3ac21f0bb848e9c35bf0140a0d98eaa1, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4745	4420	4409	4409
   q2	368	147	158	147
   q3	1450	1233	1260	1233
   q4	1107	967	921	921
   q5	3175	3187	3178	3178
   q6	248	130	134	130
   q7	987	470	490	470
   q8	2198	2214	2211	2211
   q9	6711	6665	6666	6665
   q10	3222	3284	3261	3261
   q11	304	186	185	185
   q12	357	208	212	208
   q13	4559	3812	3784	3784
   q14	240	215	212	212
   q15	575	529	523	523
   q16	439	397	387	387
   q17	1003	565	480	480
   q18	7021	6765	6840	6765
   q19	1501	1416	1474	1416
   q20	533	313	289	289
   q21	3096	2627	2693	2627
   q22	349	273	276	273
   Total cold run time: 44188 ms
   Total hot run time: 39774 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4354	4332	4329	4329
   q2	274	168	169	168
   q3	3512	3504	3489	3489
   q4	2400	2373	2374	2373
   q5	5729	5717	5688	5688
   q6	242	121	122	121
   q7	2349	1853	1828	1828
   q8	3516	3531	3516	3516
   q9	9000	8978	9021	8978
   q10	3939	4002	4008	4002
   q11	484	362	374	362
   q12	775	595	597	595
   q13	4280	3595	3545	3545
   q14	286	255	246	246
   q15	578	527	517	517
   q16	497	458	501	458
   q17	1865	1850	1858	1850
   q18	8598	8089	8056	8056
   q19	1750	1774	1753	1753
   q20	2275	1958	1947	1947
   q21	6485	6136	6160	6136
   q22	494	417	420	417
   Total cold run time: 63682 ms
   Total hot run time: 60374 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28539:
URL: https://github.com/apache/doris/pull/28539#issuecomment-1868206976

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.24 seconds
    stream load tsv:          564 seconds loaded 74807831229 Bytes, about 126 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          66 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.9 seconds inserted 10000000 Rows, about 346K ops/s
    storage size: 17187840945 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28539:
URL: https://github.com/apache/doris/pull/28539#issuecomment-1859473050

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28539:
URL: https://github.com/apache/doris/pull/28539#issuecomment-1862430850

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit 2a16d3ffda8fc0a0eb818ec4beaf5af663a7de91, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4695	4423	4423	4423
   q2	372	139	198	139
   q3	1453	1256	1260	1256
   q4	1118	895	905	895
   q5	3114	3134	3152	3134
   q6	249	128	125	125
   q7	984	502	483	483
   q8	2174	2213	2170	2170
   q9	6707	6656	6643	6643
   q10	3205	3267	3280	3267
   q11	297	183	178	178
   q12	347	202	208	202
   q13	4558	3775	3851	3775
   q14	239	220	213	213
   q15	560	520	533	520
   q16	438	378	380	378
   q17	1013	644	577	577
   q18	7195	6839	6835	6835
   q19	1556	1442	1413	1413
   q20	520	316	286	286
   q21	3025	2639	2659	2639
   q22	349	274	280	274
   Total cold run time: 44168 ms
   Total hot run time: 39825 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4369	4369	4332	4332
   q2	272	168	173	168
   q3	3543	3533	3519	3519
   q4	2388	2367	2375	2367
   q5	5746	5709	5735	5709
   q6	239	120	120	120
   q7	2380	1843	1877	1843
   q8	3507	3523	3506	3506
   q9	9002	9017	9028	9017
   q10	3929	3975	3976	3975
   q11	487	382	373	373
   q12	762	616	593	593
   q13	4268	3561	3572	3561
   q14	288	252	253	252
   q15	578	524	522	522
   q16	513	454	471	454
   q17	1893	1848	1828	1828
   q18	8656	8273	8306	8273
   q19	1746	1758	1755	1755
   q20	2239	1957	1921	1921
   q21	6529	6193	6159	6159
   q22	502	421	428	421
   Total cold run time: 63836 ms
   Total hot run time: 60668 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28539:
URL: https://github.com/apache/doris/pull/28539#issuecomment-1862195382

   TeamCity be ut coverage result:
    Function Coverage: 36.48% (8532/23386) 
    Line Coverage: 28.62% (69356/242340)
    Region Coverage: 27.64% (35887/129856)
    Branch Coverage: 24.36% (18329/75248)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/2a16d3ffda8fc0a0eb818ec4beaf5af663a7de91_2a16d3ffda8fc0a0eb818ec4beaf5af663a7de91/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "nanfeng1999 (via GitHub)" <gi...@apache.org>.
nanfeng1999 commented on PR #28539:
URL: https://github.com/apache/doris/pull/28539#issuecomment-1863952676

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28539:
URL: https://github.com/apache/doris/pull/28539#issuecomment-1868204279

   TeamCity be ut coverage result:
    Function Coverage: 36.59% (8549/23364) 
    Line Coverage: 28.66% (69508/242490)
    Region Coverage: 27.66% (35942/129943)
    Branch Coverage: 24.39% (18371/75324)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/e1675bbc3ac21f0bb848e9c35bf0140a0d98eaa1_e1675bbc3ac21f0bb848e9c35bf0140a0d98eaa1/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "nanfeng1999 (via GitHub)" <gi...@apache.org>.
nanfeng1999 commented on PR #28539:
URL: https://github.com/apache/doris/pull/28539#issuecomment-1862128038

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #28539:
URL: https://github.com/apache/doris/pull/28539


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28539:
URL: https://github.com/apache/doris/pull/28539#issuecomment-1868159886

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28539:
URL: https://github.com/apache/doris/pull/28539#issuecomment-1868164488

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "nanfeng1999 (via GitHub)" <gi...@apache.org>.
nanfeng1999 commented on PR #28539:
URL: https://github.com/apache/doris/pull/28539#issuecomment-1868198555

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "nanfeng1999 (via GitHub)" <gi...@apache.org>.
nanfeng1999 commented on PR #28539:
URL: https://github.com/apache/doris/pull/28539#issuecomment-1864158877

   run arm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](block) add block columns size dcheck [doris]

Posted by "nanfeng1999 (via GitHub)" <gi...@apache.org>.
nanfeng1999 commented on PR #28539:
URL: https://github.com/apache/doris/pull/28539#issuecomment-1864022287

   run arm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org